pgsql: Oops, I fumbled the backpatch of pg_upgrade changes.

Started by Heikki Linnakangasover 11 years ago4 messagescomitters
Jump to latest
#1Heikki Linnakangas
heikki.linnakangas@enterprisedb.com

Oops, I fumbled the backpatch of pg_upgrade changes.

Somehow I got 9.2 and 9.4 correct, but fumbled 9.3.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/9945f4e0f546f2e53b430fba32831ae6c73abb78

Modified Files
--------------
contrib/pg_upgrade/check.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Peter Eisentraut
peter_e@gmx.net
In reply to: Heikki Linnakangas (#1)
Re: pgsql: Oops, I fumbled the backpatch of pg_upgrade changes.

On 10/25/14 2:00 PM, Heikki Linnakangas wrote:

Oops, I fumbled the backpatch of pg_upgrade changes.

Somehow I got 9.2 and 9.4 correct, but fumbled 9.3.

This is still producing a compiler warning:

check.c:471:2: error: implicit declaration of function
'pg_valid_server_encoding' [-Werror=implicit-function-declaration]

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Michael Paquier
michael@paquier.xyz
In reply to: Peter Eisentraut (#2)
Re: pgsql: Oops, I fumbled the backpatch of pg_upgrade changes.

On Sat, Nov 1, 2014 at 10:22 PM, Peter Eisentraut <peter_e@gmx.net> wrote:

On 10/25/14 2:00 PM, Heikki Linnakangas wrote:

Oops, I fumbled the backpatch of pg_upgrade changes.

Somehow I got 9.2 and 9.4 correct, but fumbled 9.3.

This is still producing a compiler warning:

check.c:471:2: error: implicit declaration of function
'pg_valid_server_encoding' [-Werror=implicit-function-declaration]

check.c is missing an inclusion of mb/pg_wchar.h on 9.3 only.
--
Michael

Attachments:

20141101_pg_upgrade_fix_warning,patchapplication/octet-stream; name="20141101_pg_upgrade_fix_warning,patch"Download+1-0
#4Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Michael Paquier (#3)
Re: pgsql: Oops, I fumbled the backpatch of pg_upgrade changes.

On 11/01/2014 03:36 PM, Michael Paquier wrote:

On Sat, Nov 1, 2014 at 10:22 PM, Peter Eisentraut <peter_e@gmx.net> wrote:

On 10/25/14 2:00 PM, Heikki Linnakangas wrote:

Oops, I fumbled the backpatch of pg_upgrade changes.

Somehow I got 9.2 and 9.4 correct, but fumbled 9.3.

This is still producing a compiler warning:

check.c:471:2: error: implicit declaration of function
'pg_valid_server_encoding' [-Werror=implicit-function-declaration]

check.c is missing an inclusion of mb/pg_wchar.h on 9.3 only.

Thanks, fixed.

- Heikki

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers