pgsql: doc: Wording and formatting improvements in new logical decoding

Started by Peter Eisentrautover 11 years ago3 messagescomitters
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

doc: Wording and formatting improvements in new logical decoding docs

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/50709a1d427831d48a5aa14655e9f57e3721a06b

Modified Files
--------------
doc/src/sgml/logicaldecoding.sgml | 184 +++++++++++++++++++++++-----------
doc/src/sgml/ref/pg_recvlogical.sgml | 8 ++
2 files changed, 131 insertions(+), 61 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Andres Freund
andres@anarazel.de
In reply to: Peter Eisentraut (#1)
Re: pgsql: doc: Wording and formatting improvements in new logical decoding

Hi,

On 2014-10-31 02:57:21 +0000, Peter Eisentraut wrote:

doc: Wording and formatting improvements in new logical decoding docs

Thanks for looking.

One thing I noticed is that:
-# pg_recvlogical -d postgres --slot test --create-slot
-# pg_recvlogical -d postgres --slot test --start -f -
-CTRL-Z
-# psql -d postgres -c "INSERT INTO data(data) VALUES('4');"
-# fg
+$ pg_recvlogical -d postgres --slot test --create-slot
+$ pg_recvlogical -d postgres --slot test --start -f -
+<keycombo action="simul"><keycap>Control</><keycap>D</></>
+$ psql -d postgres -c "INSERT INTO data(data) VALUES('4');"
+$ fg

looks wrong to me. Note the s/Z/D/. Or was that intentional?

Also you sometimes replaced walsender interface by
"streaming-replication interface" and sometimes by 'streaming
replication interface'. Im generally not sure that replacement is an
improvement, but it should be consistent if done.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Andres Freund (#2)
Re: pgsql: doc: Wording and formatting improvements in new logical decoding

On 10/31/14 2:34 AM, Andres Freund wrote:

One thing I noticed is that:
-# pg_recvlogical -d postgres --slot test --create-slot
-# pg_recvlogical -d postgres --slot test --start -f -
-CTRL-Z
-# psql -d postgres -c "INSERT INTO data(data) VALUES('4');"
-# fg
+$ pg_recvlogical -d postgres --slot test --create-slot
+$ pg_recvlogical -d postgres --slot test --start -f -
+<keycombo action="simul"><keycap>Control</><keycap>D</></>
+$ psql -d postgres -c "INSERT INTO data(data) VALUES('4');"
+$ fg

looks wrong to me. Note the s/Z/D/. Or was that intentional?

Fart.

Also you sometimes replaced walsender interface by
"streaming-replication interface" and sometimes by 'streaming
replication interface'. Im generally not sure that replacement is an
improvement, but it should be consistent if done.

Yeah, it was only one. I fixed that, too.

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers