pg_regress config

Andrew Dunstan wrote:

I would like to add an argument to pg_regress that allows us to set some
config options for the temp install. Specifically right now I am
interested in setting the following:

log_line_prefix = '[%c] '
log_statement = 'all'
log_connections = 'true'

But I think it makes more sense to provide for a general option setting
mechanism, such as --extra_config=/path/to/some/file

This would dovetail neatly with the recent suggestion that we might
provide for buildfarm members to run several config sets.

Thoughts?

I think the file makes a lot more sense - would keep you from ending up
with really horrible commandlines. Also, it would make it easier if you
want to set up different configs manually (the buildfarm script can
always manage).

What about the ability to pass options to initdb, while you're at it?
Like changing the locale? (which will break the scripts, but it should
only break them in predictable locations)

//Magnus

Magnus Hagander wrote:

Andrew Dunstan wrote:

I would like to add an argument to pg_regress that allows us to set some
config options for the temp install. Specifically right now I am
interested in setting the following:

log_line_prefix = '[%c] '
log_statement = 'all'
log_connections = 'true'

But I think it makes more sense to provide for a general option setting
mechanism, such as --extra_config=/path/to/some/file

This would dovetail neatly with the recent suggestion that we might
provide for buildfarm members to run several config sets.

Thoughts?

I think the file makes a lot more sense - would keep you from ending up
with really horrible commandlines. Also, it would make it easier if you
want to set up different configs manually (the buildfarm script can
always manage).

OK, patch attached. I called the option 'temp-config' to go with
'temp-install'.

What about the ability to pass options to initdb, while you're at it?
Like changing the locale? (which will break the scripts, but it should
only break them in predictable locations)

Sufficient unto the day is the evil thereof. We can handle that another
time.

What I will do however is add some ability to use this to the makefiles
and the vcregress script.

cheers

andrew

Andrew Dunstan wrote:

Magnus Hagander wrote:

Andrew Dunstan wrote:

I would like to add an argument to pg_regress that allows us to set some
config options for the temp install. Specifically right now I am
interested in setting the following:

log_line_prefix = '[%c] '
log_statement = 'all'
log_connections = 'true'

But I think it makes more sense to provide for a general option setting
mechanism, such as --extra_config=/path/to/some/file

This would dovetail neatly with the recent suggestion that we might
provide for buildfarm members to run several config sets.

Thoughts?

I think the file makes a lot more sense - would keep you from ending up
with really horrible commandlines. Also, it would make it easier if you
want to set up different configs manually (the buildfarm script can
always manage).

OK, patch attached. I called the option 'temp-config' to go with
'temp-install'.

I'd have used an include statement instead of copying the whole file,
but can't see anything actually wrong with it ;-)

//Magnus