pgsql: Remove USE_VPATH make variable from PGXS
Remove USE_VPATH make variable from PGXS
The user can just set VPATH directly. There is no need to invent
another variable.
Branch
------
REL9_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/e907997f42faada60e5a26b116cc0b79b69309d1
Modified Files
--------------
doc/src/sgml/extend.sgml | 6 +++---
src/makefiles/pgxs.mk | 9 ++++-----
2 files changed, 7 insertions(+), 8 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Him
On 2014-12-04 16:35:27 +0000, Peter Eisentraut wrote:
Remove USE_VPATH make variable from PGXS
The user can just set VPATH directly. There is no need to invent
another variable.
I'm at a bit of loss why this was committed to 9.4 after rc1. This very
much can (and has) broken external software.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On 1/17/15 11:21 AM, Andres Freund wrote:
Him
On 2014-12-04 16:35:27 +0000, Peter Eisentraut wrote:
Remove USE_VPATH make variable from PGXS
The user can just set VPATH directly. There is no need to invent
another variable.I'm at a bit of loss why this was committed to 9.4 after rc1. This very
much can (and has) broken external software.
What did it break?
AFAICT, this just reverted an unnecessary "feature" (USE_VPATH) that
shadowed an existing and perfectly working feature (using VPATH directly).
I agree the timing was unfortunate.
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On 2015-01-17 11:47:32 -0500, Peter Eisentraut wrote:
On 1/17/15 11:21 AM, Andres Freund wrote:
Him
On 2014-12-04 16:35:27 +0000, Peter Eisentraut wrote:
Remove USE_VPATH make variable from PGXS
The user can just set VPATH directly. There is no need to invent
another variable.I'm at a bit of loss why this was committed to 9.4 after rc1. This very
much can (and has) broken external software.What did it break?
bdr (and/or udr). It automagically uses VPATH builds to build against
postgres.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers