pgsql: Tweaks for recovery_target_action

Started by Simon Riggsover 11 years ago3 messagescomitters
Jump to latest
#1Simon Riggs
simon@2ndQuadrant.com

Tweaks for recovery_target_action

Rename parameter action_at_recovery_target to
recovery_target_action suggested by Christoph Berg.

Place into recovery.conf suggested by Fujii Masao,
replacing (deprecating) earlier parameters, per
Michael Paquier.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/b8e33a85d4e86a8391118c3d5cdb249b560dec4f

Modified Files
--------------
src/backend/access/transam/recovery.conf.sample | 10 ++++---
src/backend/access/transam/xlog.c | 32 +++++++++++------------
2 files changed, 22 insertions(+), 20 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Michael Paquier
michael@paquier.xyz
In reply to: Simon Riggs (#1)
Re: pgsql: Tweaks for recovery_target_action

On Sun, Dec 7, 2014 at 9:59 PM, Simon Riggs <simon@2ndquadrant.com> wrote:

Tweaks for recovery_target_action

Rename parameter action_at_recovery_target to
recovery_target_action suggested by Christoph Berg.

Place into recovery.conf suggested by Fujii Masao,
replacing (deprecating) earlier parameters, per
Michael Paquier.

Robert has mentioned here
(CA+TgmoZ5aenvfrJ2+dr9Hy4z3Xay_ORqZcTz7v0qccXQohuK1A@mail.gmail.com)
as well about simply removing any reference to
pause_at_recovery_action in the code and in the docs, or at least it
is what I understood. Agreeing on this idea, I think that you would
need as well the patch attached. In any case, this commit has
forgotten to update doc/src/sgml/recovery-config.sgml, where
action_at_recovery_target is still mentioned.
Thanks,
--
Michael

Attachments:

20141208_recovery_target_fixes.patchtext/x-patch; charset=US-ASCII; name=20141208_recovery_target_fixes.patchDownload+5-58
#3Simon Riggs
simon@2ndQuadrant.com
In reply to: Michael Paquier (#2)
Re: pgsql: Tweaks for recovery_target_action

On 8 December 2014 at 08:52, Michael Paquier <michael.paquier@gmail.com> wrote:

On Sun, Dec 7, 2014 at 9:59 PM, Simon Riggs <simon@2ndquadrant.com> wrote:

Tweaks for recovery_target_action

Rename parameter action_at_recovery_target to
recovery_target_action suggested by Christoph Berg.

Place into recovery.conf suggested by Fujii Masao,
replacing (deprecating) earlier parameters, per
Michael Paquier.

Robert has mentioned here
(CA+TgmoZ5aenvfrJ2+dr9Hy4z3Xay_ORqZcTz7v0qccXQohuK1A@mail.gmail.com)
as well about simply removing any reference to
pause_at_recovery_action in the code and in the docs, or at least it
is what I understood. Agreeing on this idea, I think that you would
need as well the patch attached.

Not sure I agree, but we can clean it up at the end if we still care, and agree.

In any case, this commit has
forgotten to update doc/src/sgml/recovery-config.sgml, where
action_at_recovery_target is still mentioned.
Thanks,

Corrected thanks.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers