pgsql: Minor cleanup/code review for "indirect toast" stuff.

Minor cleanup/code review for "indirect toast" stuff.

Fix some issues I noticed while fooling with an extension to allow an
additional kind of toast pointer. Much of this is just comment
improvement, but there are a couple of actual bugs, which might or might
not be reachable today depending on what can happen during logical
decoding. An example is that toast_flatten_tuple() failed to cover the
possibility of an indirection pointer in its input. Back-patch to 9.4
just in case that is reachable now.

In HEAD, also correct some really minor issues with recent compression
reorganization, such as dangerously underparenthesized macros.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/bc4de01db3a210e988dc88b585d7c38e6e7054c7

Modified Files
--------------
src/backend/access/heap/tuptoaster.c | 65 +++++++++++++++++++++++-----------
src/include/access/tuptoaster.h | 6 ++--
src/include/postgres.h | 37 +++++++++----------
3 files changed, 66 insertions(+), 42 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers