Unclarity of configure options

Nikolay Samokhvalov wrote:

The current (CVS version) configure script has the following options
(among many others):

--enable-dtrace build with DTrace support
--with-ossp-uuid build with OSSP UUID library for UUID generation
--with-libxml build with XML support
--with-libxslt build with XSLT support

One could think that adding any of this option to ./configure before
building Postgres from sources, he will have corresponding support
after installation and initdb process. But what we have now is the
huge difference between "--with-libxml" and "--with-libxslt": while
the first one adds XML support to the core, the second one doesn't
provide anything automatically, it allows only using contirb/xml2
(what is unclear because the help message is the same as for
--with-libxml -- "build with ... support").

I have modified the configure message to be:

--with-libxslt build /contrib/xml2 with XSLT support

Patch attached.

Also, comparing --enable-dtrace and --with-libxml I cannot see any
difference in its semantics: --enable-dtrace also depends on external
library and configure process fails if the system doesn't have it. So
why "--enable-" is used in the first case and "--with-" in the second
one?

I think the reason for this is because XML is seen as something added to
the backend (new capability) while dtrace is embedded in the backend.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, 4 Nov 2007 13:11:00 -0500 (EST)
Bruce Momjian <bruce@momjian.us> wrote:

Nikolay Samokhvalov wrote:

The current (CVS version) configure script has the following options
(among many others):

--enable-dtrace build with DTrace support
--with-ossp-uuid build with OSSP UUID library for UUID
generation --with-libxml build with XML support
--with-libxslt build with XSLT support

One could think that adding any of this option to ./configure before
building Postgres from sources, he will have corresponding support
after installation and initdb process. But what we have now is the
huge difference between "--with-libxml" and "--with-libxslt": while
the first one adds XML support to the core, the second one doesn't
provide anything automatically, it allows only using contirb/xml2
(what is unclear because the help message is the same as for
--with-libxml -- "build with ... support").

I have modified the configure message to be:

--with-libxslt build /contrib/xml2 with XSLT support

Patch attached.

Shouldn't --with-libxml be noted as deprecated?

Joshua D. Drake

- --

=== The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 24x7/Emergency: +1.800.492.2240
PostgreSQL solutions since 1997 http://www.commandprompt.com/
UNIQUE NOT NULL
Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate
PostgreSQL Replication: http://www.commandprompt.com/products/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHLgwBATb/zqfZUUQRAsLYAJ9xIrfHnidg0BPW6durNvl61VVT8wCfdY4i
kKSUyVxwaFazYlcY7SCkiCY=
=A8DO
-----END PGP SIGNATURE-----

"Joshua D. Drake" <jd@commandprompt.com> writes:

Shouldn't --with-libxml be noted as deprecated?

Huh?

regards, tom lane

Bruce Momjian <bruce@momjian.us> writes:

I have modified the configure message to be:
--with-libxslt build /contrib/xml2 with XSLT support

This turns the message from something merely a tad unclear into an
outright lie. "--with-libxslt" does not cause contrib/xml2 (or any
other part of contrib) to get built. Better would be

--with-libxslt build with XSLT (affects only contrib/xml2)

regards, tom lane

Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

I have modified the configure message to be:
--with-libxslt build /contrib/xml2 with XSLT support

This turns the message from something merely a tad unclear into an
outright lie. "--with-libxslt" does not cause contrib/xml2 (or any
other part of contrib) to get built. Better would be

--with-libxslt build with XSLT (affects only contrib/xml2)

Updated wording:

--with-libxslt use XSLT support when building /contrib/xml2

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, 04 Nov 2007 13:24:54 -0500
Tom Lane <tgl@sss.pgh.pa.us> wrote:

"Joshua D. Drake" <jd@commandprompt.com> writes:

Shouldn't --with-libxml be noted as deprecated?

Huh?

Because in 8.3 it is in core or am I misunderstanding the difference?

Joshua D. Drake

regards, tom lane

---------------------------(end of
broadcast)--------------------------- TIP 1: if posting/reading
through Usenet, please send an appropriate subscribe-nomail command
to majordomo@postgresql.org so that your message can get through to
the mailing list cleanly

- --

=== The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 24x7/Emergency: +1.800.492.2240
PostgreSQL solutions since 1997 http://www.commandprompt.com/
UNIQUE NOT NULL
Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate
PostgreSQL Replication: http://www.commandprompt.com/products/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHLhmXATb/zqfZUUQRAuBJAJ9jFV8DaxWzWJKhjIPTkeXZ1OWRVQCfTaiV
5ytxcL5Q+Xc3tEAxoj7bbPY=
=tLkt
-----END PGP SIGNATURE-----

Joshua D. Drake wrote:

On Sun, 04 Nov 2007 13:24:54 -0500
Tom Lane <tgl@sss.pgh.pa.us> wrote:

"Joshua D. Drake" <jd@commandprompt.com> writes:

Shouldn't --with-libxml be noted as deprecated?

Huh?

Because in 8.3 it is in core or am I misunderstanding the difference?

you missunderstand - the XML support in 8.3 requires libxml and is only
compiled in if that configure switch is selected ...

Stefan

Joshua D. Drake wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, 04 Nov 2007 13:24:54 -0500
Tom Lane <tgl@sss.pgh.pa.us> wrote:

"Joshua D. Drake" <jd@commandprompt.com> writes:

Shouldn't --with-libxml be noted as deprecated?

Huh?

Because in 8.3 it is in core or am I misunderstanding the difference?

The functionality is in 8.3 and we areC keeping the /contrib/xml2 API
around for those who need it. The release notes have:

* "contrib/xml2" is deprecated and planned for removal in 8.4 (Peter)
The new XML support in core Postgres supersedes this module.

Do we need more than that? I don't think so.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Stefan Kaltenbrunner wrote:

Joshua D. Drake wrote:

On Sun, 04 Nov 2007 13:24:54 -0500
Tom Lane <tgl@sss.pgh.pa.us> wrote:

"Joshua D. Drake" <jd@commandprompt.com> writes:

Shouldn't --with-libxml be noted as deprecated?

Huh?

Because in 8.3 it is in core or am I misunderstanding the difference?

you missunderstand - the XML support in 8.3 requires libxml and is only
compiled in if that configure switch is selected ...

Right, that too.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, 4 Nov 2007 14:17:48 -0500 (EST)
Bruce Momjian <bruce@momjian.us> wrote:

The functionality is in 8.3 and we areC keeping the /contrib/xml2 API
around for those who need it. The release notes have:

* "contrib/xml2" is deprecated and planned for removal in 8.4
(Peter) The new XML support in core Postgres supersedes this module.

Do we need more than that? I don't think so.

Well that was exactly my point, contrib/xml2 is deprecated as of 8.3 so
it may make sense to make sure the configure says exactly that.

If not, it isn't that big of a deal. I was just making a suggestion to
try and help stop confusion in the future.

Sincerely,

Joshua D. Drake

- --

=== The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 24x7/Emergency: +1.800.492.2240
PostgreSQL solutions since 1997 http://www.commandprompt.com/
UNIQUE NOT NULL
Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate
PostgreSQL Replication: http://www.commandprompt.com/products/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHLhz1ATb/zqfZUUQRAmBcAJ9ToftpalD9kH5x+Vwy+SVHn6qB8ACbBB4d
D+lV9utI9iNhlK7F0qjhFMk=
=uovh
-----END PGP SIGNATURE-----

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, 4 Nov 2007 14:18:23 -0500 (EST)
Bruce Momjian <bruce@momjian.us> wrote:

Stefan Kaltenbrunner wrote:

Joshua D. Drake wrote:

On Sun, 04 Nov 2007 13:24:54 -0500
Tom Lane <tgl@sss.pgh.pa.us> wrote:

"Joshua D. Drake" <jd@commandprompt.com> writes:

Shouldn't --with-libxml be noted as deprecated?

Huh?

Because in 8.3 it is in core or am I misunderstanding the
difference?

you missunderstand - the XML support in 8.3 requires libxml and is
only compiled in if that configure switch is selected ...

Right, that too.

Aha! O.k. that is what I missed. Suggestion withdrawn.

Sincerely,

Joshua D. Drake

- --

=== The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 24x7/Emergency: +1.800.492.2240
PostgreSQL solutions since 1997 http://www.commandprompt.com/
UNIQUE NOT NULL
Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate
PostgreSQL Replication: http://www.commandprompt.com/products/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHLh0oATb/zqfZUUQRAhVEAJ4nW8AS+gR7EOKl4UY4e7NCc/hFHACgmtpU
brAYEQ+UhIMBWL9wxQFM+CA=
=B7xe
-----END PGP SIGNATURE-----

Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

I have modified the configure message to be:
--with-libxslt build /contrib/xml2 with XSLT support

This turns the message from something merely a tad unclear into an
outright lie. "--with-libxslt" does not cause contrib/xml2 (or any
other part of contrib) to get built. Better would be

--with-libxslt build with XSLT (affects only contrib/xml2)

What is more, if we're going to do this we should mark *all* the options
that only affect contrib, which is why I objected to doing this on its
own in the first place.

cheers

andrew

Andrew Dunstan wrote:

Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

I have modified the configure message to be:
--with-libxslt build /contrib/xml2 with XSLT support

This turns the message from something merely a tad unclear into an
outright lie. "--with-libxslt" does not cause contrib/xml2 (or any
other part of contrib) to get built. Better would be

--with-libxslt build with XSLT (affects only contrib/xml2)

What is more, if we're going to do this we should mark *all* the options
that only affect contrib, which is why I objected to doing this on its
own in the first place.

Uh, what other configure options to we have that only affect /contrib?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Bruce Momjian wrote:

Andrew Dunstan wrote:

Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

I have modified the configure message to be:
--with-libxslt build /contrib/xml2 with XSLT support

This turns the message from something merely a tad unclear into an
outright lie. "--with-libxslt" does not cause contrib/xml2 (or any
other part of contrib) to get built. Better would be

--with-libxslt build with XSLT (affects only contrib/xml2)

What is more, if we're going to do this we should mark *all* the options
that only affect contrib, which is why I objected to doing this on its
own in the first place.

Uh, what other configure options to we have that only affect /contrib?

--with-ossp-uuid at least, IIRC

This was discussed previously, BTW. Maybe you haven't read all the mail.

Note that

cheers

andrew

Andrew Dunstan wrote:

Bruce Momjian wrote:

Andrew Dunstan wrote:

Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

I have modified the configure message to be:
--with-libxslt build /contrib/xml2 with XSLT support

This turns the message from something merely a tad unclear into an
outright lie. "--with-libxslt" does not cause contrib/xml2 (or any
other part of contrib) to get built. Better would be

--with-libxslt build with XSLT (affects only contrib/xml2)

What is more, if we're going to do this we should mark *all* the options
that only affect contrib, which is why I objected to doing this on its
own in the first place.

Uh, what other configure options to we have that only affect /contrib?

--with-ossp-uuid at least, IIRC

This was discussed previously, BTW. Maybe you haven't read all the mail.

Sorry, no I missed that. Patch attached and applied.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +