pgsql: Add missing installcheck target to pg_rewind's Makefile

Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:

Add missing installcheck target to pg_rewind's Makefile

This patch seems a brick shy of a load, in that "make installcheck" in
bin/pg_rewind leaves behind a bunch of junk in a tmp_check/ subdirectory.
installcheck in any other src/bin/ subdirectory doesn't do that.

(I chanced to notice this while wondering why hamster is failing on
this test. I can't reproduce the failure locally, but ...)

regards, tom lane

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

On Wed, Apr 22, 2015 at 5:38 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

(I chanced to notice this while wondering why hamster is failing on
this test. I can't reproduce the failure locally, but ...)

With a very slow environment you will be able to reproduce the failure.
--
Michael

On 04/21/2015 11:38 PM, Tom Lane wrote:

Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:

Add missing installcheck target to pg_rewind's Makefile

This patch seems a brick shy of a load, in that "make installcheck" in
bin/pg_rewind leaves behind a bunch of junk in a tmp_check/ subdirectory.
installcheck in any other src/bin/ subdirectory doesn't do that.

Ok, fixed.

It would actually be quite useful to leave tmp_check behind if the test
fails, for debugging purposes. Not just in pg_rewind, but in the other
subdirectories too. Another patch for another day..

- Heikki

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers