pgsql: Fix portability issue in pg_audit.

Started by Tom Laneabout 11 years ago3 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Fix portability issue in pg_audit.

"%ld" is not a portable way to print int64's. This may explain the
buildfarm crashes we're seeing --- it seems to make dromedary happy,
at least.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/35a1e1d1593f4355c9d87bbc8208a8736801a607

Modified Files
--------------
contrib/pg_audit/pg_audit.c | 35 ++++++++++++++++++++---------------
1 file changed, 20 insertions(+), 15 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Tom Lane (#1)
Re: pgsql: Fix portability issue in pg_audit.

Tom Lane wrote:

Fix portability issue in pg_audit.

"%ld" is not a portable way to print int64's. This may explain the
buildfarm crashes we're seeing --- it seems to make dromedary happy,
at least.

FWIW you could use %zd for translatability, assuming we ever get
pg_audit translatable.

--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#2)
Re: pgsql: Fix portability issue in pg_audit.

Alvaro Herrera <alvherre@2ndquadrant.com> writes:

Tom Lane wrote:

"%ld" is not a portable way to print int64's. This may explain the
buildfarm crashes we're seeing --- it seems to make dromedary happy,
at least.

FWIW you could use %zd for translatability, assuming we ever get
pg_audit translatable.

Really? z means size_t.

regards, tom lane

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers