pgsql: Improve error message and hint for ALTER COLUMN TYPE can't-cast

Started by Tom Laneabout 11 years ago1 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Improve error message and hint for ALTER COLUMN TYPE can't-cast failure.

We already tried to improve this once, but the "improved" text was rather
off-target if you had provided a USING clause. Also, it seems helpful
to provide the exact text of a suggested USING clause, so users can just
copy-and-paste it when needed. Per complaint from Keith Rarick and a
suggestion from Merlin Moncure.

Back-patch to 9.2 where the current wording was adopted.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/ae6ae424b502afcc514a2ce14de476a9714b6a75

Modified Files
--------------
src/backend/commands/tablecmds.c | 25 ++++++++++++++++++++-----
src/test/regress/expected/alter_table.out | 7 +++++--
src/test/regress/sql/alter_table.sql | 1 +
3 files changed, 26 insertions(+), 7 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers