pgsql: Temporarily(?) remove BRIN isolation test.
Temporarily(?) remove BRIN isolation test.
Commit 2834855cb added a not-very-carefully-thought-out isolation test
to check a BRIN index bug fix. The test depended on the availability
of the pageinspect contrib module, which meant it did not work in
several common testing scenarios such as "make check-world". It's not
clear whether we want a core test depending on a contrib module like
that, but in any case, failing to deal with the possibility that the
module isn't present in the installation-under-test is not acceptable.
Remove that test pending some better solution.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/6a1e14c62b739a754335c088474e12f42a6763bd
Modified Files
--------------
src/test/isolation/expected/brin-1.out | 39 ----------------------------
src/test/isolation/isolation_schedule | 1 -
src/test/isolation/specs/brin-1.spec | 44 --------------------------------
3 files changed, 84 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Tom Lane wrote:
Temporarily(?) remove BRIN isolation test.
Sorry about that, I intended to do it this AM but ran into stupid
network issues.
BRIN needs a lot more tests ISTM, so I'm thinking in adding
src/test/modules/brin which would include this isolation test and have
an extra-install for pageinspect, along with additional tests.
--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
Tom Lane wrote:
Temporarily(?) remove BRIN isolation test.
Sorry about that, I intended to do it this AM but ran into stupid
network issues.
Ah, I was wondering why you'd not responded.
BRIN needs a lot more tests ISTM, so I'm thinking in adding
src/test/modules/brin which would include this isolation test and have
an extra-install for pageinspect, along with additional tests.
Seems like a reasonable plan.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers