pgsql: Be more wary about partially-valid LOCALLOCK data in RemoveLocal

Started by Tom Lanealmost 11 years ago1 messagescomitters

tgl@sss.pgh.pa.us

almost 11 years ago

Be more wary about partially-valid LOCALLOCK data in RemoveLocalLock().

RemoveLocalLock() must consider the possibility that LockAcquireExtended()
failed to palloc the initial space for a locallock's lockOwners array.
I had evidently meant to cope with this hazard when the code was originally
written (commit 1785acebf2ed14fd66955e2d9a55d77a025f418d), but missed that
the pfree needed to be protected with an if-test. Just to make sure things
are left in a clean state, reset numLockOwners as well.

Per low-memory testing by Andreas Seltenreich. Back-patch to all supported
branches.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/ac0c71228fe7e44d9eba130df9bbbb5c2bfa9faa

Modified Files
--------------
src/backend/storage/lmgr/lock.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers