pgsql: Restrict file mode creation mask during tmpfile().

Started by Noah Mischalmost 11 years ago3 messagescomitters
Jump to latest
#1Noah Misch
noah@leadboat.com

Restrict file mode creation mask during tmpfile().

Per Coverity. Back-patch to 9.0 (all supported versions).

Michael Paquier, reviewed (in earlier versions) by Heikki Linnakangas.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/24aed2124a5273e4cb543b06d4b7bb2c2ad5bf3c

Modified Files
--------------
src/bin/pg_dump/pg_backup_tar.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Noah Misch
noah@leadboat.com
In reply to: Noah Misch (#1)
Re: pgsql: Restrict file mode creation mask during tmpfile().

On Mon, Sep 21, 2015 at 01:00:46AM +0000, Noah Misch wrote:

Restrict file mode creation mask during tmpfile().

REL9_0_STABLE

This broke buildfarm member frogmouth (Windows, gcc) on this branch only. I
will look into it.

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Andres Freund
andres@anarazel.de
In reply to: Noah Misch (#2)
Re: pgsql: Restrict file mode creation mask during tmpfile().

On 2015-09-21 11:14:10 -0400, Noah Misch wrote:

On Mon, Sep 21, 2015 at 01:00:46AM +0000, Noah Misch wrote:

Restrict file mode creation mask during tmpfile().

REL9_0_STABLE

This broke buildfarm member frogmouth (Windows, gcc) on this branch only. I
will look into it.

Seems to have broken more than just frogmouth. At least baiji,
currawong, narwahl are also affected. Likely a question of 5132ad8b only
being in 9.1+:
andres@alap3:~/src/postgresql$ git branch -r --contains 5132ad8b upstream/REL*
upstream/REL9_1_STABLE
upstream/REL9_2_STABLE
upstream/REL9_3_STABLE
upstream/REL9_4_STABLE
upstream/REL9_5_STABLE

Greetings,

Andres Freund

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers