pgsql: Message improvements

Started by Peter Eisentrautover 10 years ago3 messagescomitters
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

Message improvements

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5db837d3f22960c2fdc11b390ecf3984b3e0c49e

Modified Files
--------------
src/backend/access/transam/parallel.c | 6 +++---
src/backend/access/transam/xlog.c | 27 ++++++++++++++-----------
src/backend/catalog/objectaddress.c | 4 ++--
src/backend/commands/copy.c | 2 +-
src/backend/commands/extension.c | 2 +-
src/backend/commands/tablecmds.c | 20 +++++++-----------
src/backend/commands/tablespace.c | 4 ++--
src/backend/libpq/auth.c | 3 +--
src/backend/libpq/pqcomm.c | 2 +-
src/backend/parser/parse_agg.c | 2 +-
src/backend/parser/parse_clause.c | 2 +-
src/backend/parser/parse_relation.c | 4 ++--
src/backend/postmaster/postmaster.c | 6 ++++--
src/backend/storage/lmgr/lwlock.c | 8 ++++----
src/backend/utils/adt/array_userfuncs.c | 2 +-
src/backend/utils/adt/encode.c | 4 ++--
src/backend/utils/adt/jsonb.c | 6 +++---
src/backend/utils/misc/guc.c | 6 +++---
src/backend/utils/misc/rls.c | 2 +-
src/port/win32error.c | 4 ++--
src/test/regress/expected/alter_table.out | 12 +++++------
src/test/regress/expected/insert_conflict.out | 6 +++---
src/test/regress/expected/join.out | 8 ++++----
src/test/regress/expected/jsonb.out | 2 +-
src/test/regress/expected/object_address.out | 6 +++---
src/test/regress/expected/rowsecurity.out | 10 ++++-----
26 files changed, 78 insertions(+), 82 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

In reply to: Peter Eisentraut (#1)
Re: pgsql: Message improvements

On 17-11-2015 00:07, Peter Eisentraut wrote:

Message improvements

--- a/src/backend/commands/copy.c
+++ b/src/backend/commands/copy.c
@@ -874,7 +874,7 @@ DoCopy(const CopyStmt *stmt, const char 
*queryString, uint64 *processed)
             if (is_from)
                 ereport(ERROR,
                         (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-          errmsg("COPY FROM not supported with row level security."),
+          errmsg("COPY FROM not supported with row-level security."),
                          errhint("Use INSERT statements instead.")));

It seems you forgot to remove punctuation from errmsg.

--
Euler Taveira Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Euler Taveira de Oliveira (#2)
Re: pgsql: Message improvements

On 11/16/15 10:51 PM, Euler Taveira wrote:

On 17-11-2015 00:07, Peter Eisentraut wrote:

Message improvements

--- a/src/backend/commands/copy.c
+++ b/src/backend/commands/copy.c
@@ -874,7 +874,7 @@ DoCopy(const CopyStmt *stmt, const char
*queryString, uint64 *processed)
if (is_from)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-          errmsg("COPY FROM not supported with row level security."),
+          errmsg("COPY FROM not supported with row-level security."),
errhint("Use INSERT statements instead.")));

It seems you forgot to remove punctuation from errmsg.

Good catch! Fixed.

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers