pgsql: some bullshit

Started by Alvaro Herreraover 10 years ago5 messagescomitters
Jump to latest
#1Alvaro Herrera
alvherre@2ndquadrant.com

some bullshit

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/653530c8b1963bf91e19d03305dd0df5ad776bec

Modified Files
--------------
src/backend/commands/typecmds.c | 4 ++++
1 file changed, 4 insertions(+)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Alvaro Herrera (#1)
Re: pgsql: some bullshit

Alvaro Herrera wrote:

some bullshit

This commit was supposed to be squashed with the next one --- hence
the, err, not-terribly-descriptive commit message. This mistake may
cause future "git bisect" runs to give spurious failures, but I'm
disinclined to remove it from history nonetheless. These changes (which
would cause a compile to fail on this branch) are removed by the next
commit.

--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Robert Haas
robertmhaas@gmail.com
In reply to: Alvaro Herrera (#2)
Re: pgsql: some bullshit

On Mon, Dec 21, 2015 at 6:16 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:

Alvaro Herrera wrote:

some bullshit

This commit was supposed to be squashed with the next one --- hence
the, err, not-terribly-descriptive commit message.

Seems pretty descriptive to me!

This made me laugh so hard that I started crying. Clearly, I need a life.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#4Michael Paquier
michael@paquier.xyz
In reply to: Alvaro Herrera (#2)
Re: pgsql: some bullshit

On Tue, Dec 22, 2015 at 8:16 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:

Alvaro Herrera wrote:

some bullshit

This commit was supposed to be squashed with the next one --- hence
the, err, not-terribly-descriptive commit message. This mistake may
cause future "git bisect" runs to give spurious failures, but I'm
disinclined to remove it from history nonetheless. These changes (which
would cause a compile to fail on this branch) are removed by the next
commit.

That's not the first time something that breaks compilation of the
backend has been committed, and among all the things that already
happened nobody yet complained about a bisect failing. So no worries
regarding that and take it easy :)
--
Michael

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#5Simon Riggs
simon@2ndQuadrant.com
In reply to: Robert Haas (#3)
Re: pgsql: some bullshit

On 22 December 2015 at 05:06, Robert Haas <robertmhaas@gmail.com> wrote:

On Mon, Dec 21, 2015 at 6:16 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:

Alvaro Herrera wrote:

some bullshit

This commit was supposed to be squashed with the next one --- hence
the, err, not-terribly-descriptive commit message.

Seems pretty descriptive to me!

The lack of detail regarding coverage and authorship concerns me. Will this
be backpatched?

--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/&gt;
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services