pgsql: Further improvements to c8f621c43.

Started by Andres Freundover 10 years ago1 messagescomitters

andres@anarazel.de

over 10 years ago

Further improvements to c8f621c43.

Coverity and inspection for the issue addressed in fd45d16f found some
questionable code.

Specifically coverity noticed that the wrong length was added in
ReorderBufferSerializeChange() - without immediate negative consequences
as the variable isn't used afterwards. During code-review and testing I
noticed that a bit of space was wasted when allocating tuple bufs in
several places. Thirdly, the debug memset()s in
ReorderBufferGetTupleBuf() reduce the error checking valgrind can do.

Backpatch: 9.4, like c8f621c43.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/250e5bd7129d0b54594dc225f7380545189b70c1

Modified Files
--------------
src/backend/replication/logical/decode.c | 28 +++++++++++++++++--------
src/backend/replication/logical/reorderbuffer.c | 5 ++++-
2 files changed, 23 insertions(+), 10 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers