pgsql: Don't trust CreateFileMapping() to clear the error code on succe

Started by Tom Lanealmost 10 years ago1 messagescomitters

tgl@sss.pgh.pa.us

almost 10 years ago

Don't trust CreateFileMapping() to clear the error code on success.

We must test GetLastError() even when CreateFileMapping() returns a
non-null handle. If that value were left over from some previous system
call, we might be fooled into thinking the segment already existed.
Experimentation on Windows 7 suggests that CreateFileMapping() clears
the error code on success, but it is not documented to do so, so let's
not rely on that happening in all Windows releases.

Amit Kapila

Discussion: <20811.1474390987@sss.pgh.pa.us>

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/eda5e908291e80df9ea2ff5b6a9fd026719de2a6

Modified Files
--------------
src/backend/storage/ipc/dsm_impl.c | 3 +++
1 file changed, 3 insertions(+)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers