pgsql: Don't build the win32 support files in the all target, only in

Started by Nonamealmost 18 years ago6 messages

petere@postgresql.org

almost 18 years ago

Log Message:
-----------
Don't build the win32 support files in the all target, only in distprep and
when they are actually needed as prerequisites.

Modified Files:
--------------
pgsql/src:
Makefile.shlib (r1.112 -> r1.113)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/Makefile.shlib?r1=1.112&r2=1.113)
pgsql/src/interfaces/libpq:
Makefile (r1.162 -> r1.163)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/Makefile?r1=1.162&r2=1.163)

Andrew Dunstan

andrew@dunslane.net

almost 18 years ago

In reply to: Noname (#1)

Re: pgsql: Don't build the win32 support files in the all target, only in

This appears to have broken Win32 Mingw builds - see
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=dawn_bat&dt=2008-02-26%2007:00:01

cheers

andrew

Peter Eisentraut wrote:

Show quoted text

Log Message:
-----------
Don't build the win32 support files in the all target, only in distprep and
when they are actually needed as prerequisites.

Modified Files:
--------------
pgsql/src:
Makefile.shlib (r1.112 -> r1.113)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/Makefile.shlib?r1=1.112&r2=1.113)
pgsql/src/interfaces/libpq:
Makefile (r1.162 -> r1.163)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/Makefile?r1=1.162&r2=1.163)

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Peter Eisentraut

peter_e@gmx.net

almost 18 years ago

In reply to: Andrew Dunstan (#2)

Re: [COMMITTERS] pgsql: Don't build the win32 support files in the all target, only in

Am Dienstag, 26. Februar 2008 schrieb Andrew Dunstan:

This appears to have broken Win32 Mingw builds - see
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=dawn_bat&dt=2008-02-26%20
07:00:01

There have been a few changes after that. Let's see what is says in a few
hours.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

Hiroshi Saito

z-saito@guitar.ocn.ne.jp

almost 18 years ago

In reply to: Noname (#1)

1 attachment(s)

Re: pgsql: Don't build the win32 support files in the all target, only in

Oops, and need this patch..
please check it.

make[2]: Entering directory `/home/hiroshi/pgsql/src/timezone'
make[2]: *** No rule to make target `|', needed by `objfiles.txt'. Stop.
make[2]: Leaving directory `/home/hiroshi/pgsql/src/timezone'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/hiroshi/pgsql/src'
make: *** [all] Error 2

I checked MinGW and FreeBSD.

Regards,
Hiroshi Saito

----- Original Message -----
From: "Peter Eisentraut" <petere@postgresql.org>

Show quoted text

Log Message:
-----------
Don't build the win32 support files in the all target, only in distprep and
when they are actually needed as prerequisites.

Attachments:

win32_common_patchapplication/octet-stream; name=win32_common_patchDownload

*** src/backend/common.mk.orig	Wed Feb 27 15:47:48 2008
--- src/backend/common.mk	Wed Feb 27 15:48:26 2008
***************
*** 26,32 ****
  SUBSYS.o: $(SUBDIROBJS) $(OBJS)
  	$(LD) $(LDREL) $(LDOUT) $@ $^
  
! objfiles.txt:: $(MAKEFILE_LIST) | $(SUBDIROBJS) $(OBJS)
  	( $(if $(SUBDIROBJS),cat $(SUBDIROBJS); )echo $(addprefix $(subdir)/,$(OBJS)) ) >$@
  
  objfiles.txt:: $(SUBDIROBJS) $(OBJS)
--- 26,32 ----
  SUBSYS.o: $(SUBDIROBJS) $(OBJS)
  	$(LD) $(LDREL) $(LDOUT) $@ $^
  
! objfiles.txt:: $(MAKEFILE_LIST) $(SUBDIROBJS) $(OBJS)
  	( $(if $(SUBDIROBJS),cat $(SUBDIROBJS); )echo $(addprefix $(subdir)/,$(OBJS)) ) >$@
  
  objfiles.txt:: $(SUBDIROBJS) $(OBJS)

Bruce Momjian

bruce@momjian.us

almost 18 years ago

In reply to: Hiroshi Saito (#4)

Re: pgsql: Don't build the win32 support files in the all target, only in

FYI, this has been fixed, but in a different way that you suggested.

---------------------------------------------------------------------------

Hiroshi Saito wrote:

Oops, and need this patch..
please check it.

make[2]: Entering directory `/home/hiroshi/pgsql/src/timezone'
make[2]: *** No rule to make target `|', needed by `objfiles.txt'. Stop.
make[2]: Leaving directory `/home/hiroshi/pgsql/src/timezone'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/hiroshi/pgsql/src'
make: *** [all] Error 2

I checked MinGW and FreeBSD.

Regards,
Hiroshi Saito

----- Original Message -----
From: "Peter Eisentraut" <petere@postgresql.org>

Log Message:
-----------
Don't build the win32 support files in the all target, only in distprep and
when they are actually needed as prerequisites.

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Hiroshi Saito

z-saito@guitar.ocn.ne.jp

almost 18 years ago

In reply to: Bruce Momjian (#5)

Re: pgsql: Don't build the win32 support files in the all target, only in

Hi.

----- Original Message -----
From: "Bruce Momjian" <bruce@momjian.us>

FYI, this has been fixed, but in a different way that you suggested.

Yeah, it is very good condition CVS-HEAD now:-)
Thanks!!

Regards,
Hiroshi Saito