pgsql: Fill in no_priv_msg for publications and subscriptions
Fill in no_priv_msg for publications and subscriptions
Even though these messages are not used yet, we should keep the list
complete.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/e630faacd8a0c998db105a7d3fca063eb29b0eea
Modified Files
--------------
src/backend/catalog/aclchk.c | 4 ++++
1 file changed, 4 insertions(+)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Peter Eisentraut wrote:
Fill in no_priv_msg for publications and subscriptions
Even though these messages are not used yet, we should keep the list
complete.
Hmm, should we add a StaticAssert() somewhere that lengthof(msg_no_priv)
is somehow consistent with the AclObjectKind enum? Probably in
aclcheck_error() itself.
--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
On 1/26/17 4:46 PM, Alvaro Herrera wrote:
Peter Eisentraut wrote:
Fill in no_priv_msg for publications and subscriptions
Even though these messages are not used yet, we should keep the list
complete.Hmm, should we add a StaticAssert() somewhere that lengthof(msg_no_priv)
is somehow consistent with the AclObjectKind enum? Probably in
aclcheck_error() itself.
Maybe, but I think it's not that important, because an actual test of
the permissions will easily show when something is missing or wrong.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Peter Eisentraut wrote:
On 1/26/17 4:46 PM, Alvaro Herrera wrote:
Peter Eisentraut wrote:
Fill in no_priv_msg for publications and subscriptions
Even though these messages are not used yet, we should keep the list
complete.Hmm, should we add a StaticAssert() somewhere that lengthof(msg_no_priv)
is somehow consistent with the AclObjectKind enum? Probably in
aclcheck_error() itself.Maybe, but I think it's not that important, because an actual test of
the permissions will easily show when something is missing or wrong.
True.
--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers