pgsql: Suppress "unused variable" warnings with older versions of flex.

Started by Tom Laneover 9 years ago1 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Suppress "unused variable" warnings with older versions of flex.

Versions of flex before 2.5.36 might generate code that results in an
"unused variable" warning, when using %option reentrant. Historically
we've worked around that by specifying -Wno-error, but that's an
unsatisfying solution. The official "fix" for this was just to insert a
dummy reference to the variable, so write a small perl script that edits
the generated C code similarly.

The MSVC side of this is untested, but the buildfarm should soon reveal
if I broke that.

Discussion: /messages/by-id/25456.1487437842@sss.pgh.pa.us

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/65d508fd4decee4d5a54c1e7b93acd25d5e80556

Modified Files
--------------
src/Makefile.global.in | 1 +
src/backend/parser/Makefile | 7 +----
src/bin/psql/Makefile | 6 +---
src/fe_utils/Makefile | 6 +---
src/tools/fix-flex-warning.pl | 65 +++++++++++++++++++++++++++++++++++++++++++
src/tools/msvc/pgflex.pl | 20 ++++++++-----
6 files changed, 82 insertions(+), 23 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers