pgsql: Suppress implicit-conversion warnings seen with newer clang vers

Started by Tom Laneabout 9 years ago1 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Suppress implicit-conversion warnings seen with newer clang versions.

We were assigning values near 255 through "char *" pointers. On machines
where char is signed, that's not entirely kosher, and it's reasonable
for compilers to warn about it.

A better solution would be to change the pointer type to "unsigned char *",
but that would be vastly more invasive. For the moment, let's just apply
this simple backpatchable solution.

Aleksander Alekseev

Discussion: /messages/by-id/20170220141239.GD12278@e733.localdomain
Discussion: /messages/by-id/2839.1490714708@sss.pgh.pa.us

Branch
------
REL9_6_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/8433e0b40e0d840b8daa80eb9788fafcf2dc5aab

Modified Files
--------------
src/backend/access/transam/xlog.c | 2 +-
src/backend/access/transam/xloginsert.c | 6 +++---
src/bin/pg_resetxlog/pg_resetxlog.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers