pgsql: Remove bogus redefinition of _MSC_VER.

Started by Tom Laneabout 9 years ago2 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Remove bogus redefinition of _MSC_VER.

Commit a4777f355 was a shade too mechanical: we don't want to override
MSVC's own definition of _MSC_VER, as that breaks tests on its numerical
value. Per buildfarm.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/587d62d8562d658a2a9be60bc4574b6f9e592cb1

Modified Files
--------------
src/tools/msvc/ecpg_regression.proj | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Magnus Hagander
magnus@hagander.net
In reply to: Tom Lane (#1)
Re: pgsql: Remove bogus redefinition of _MSC_VER.

Thanks!

The sad thing is that I did that file manually first, the right way. Then I
realized I was going down the wrong track and made the change mechanical
instead. And forgot to change that one back..

Oops.

//Magnus

On Tue, Apr 11, 2017 at 9:32 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Remove bogus redefinition of _MSC_VER.

Commit a4777f355 was a shade too mechanical: we don't want to override
MSVC's own definition of _MSC_VER, as that breaks tests on its numerical
value. Per buildfarm.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/587d62d8562d658a2a9be60bc4574b
6f9e592cb1

Modified Files
--------------
src/tools/msvc/ecpg_regression.proj | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/&gt;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/&gt;