pgsql: Fix order of arguments to SubTransSetParent().

Started by Tom Laneabout 9 years ago1 messagescomitters

tgl@sss.pgh.pa.us

about 9 years ago

Fix order of arguments to SubTransSetParent().

ProcessTwoPhaseBuffer (formerly StandbyRecoverPreparedTransactions)
mixed up the parent and child XIDs when calling SubTransSetParent to
record the transactions' relationship in pg_subtrans.

Remarkably, analysis by Simon Riggs suggests that this doesn't lead to
visible problems (at least, not in non-Assert builds). That might
explain why we'd not noticed it before. Nonetheless, it's surely wrong.

This code was born broken, so back-patch to all supported branches.

Discussion: /messages/by-id/20110.1492905318@sss.pgh.pa.us

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2e14541c4992e5a2de6b5be2f7ed3f3062ed4ec1

Modified Files
--------------
src/backend/access/transam/twophase.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers