pgsql: Implement a few changes to how shared libraries and dynamically

Started by Nonamealmost 18 years ago4 messages

petere@postgresql.org

almost 18 years ago

Log Message:
-----------
Implement a few changes to how shared libraries and dynamically loadable
modules are built. Foremost, it creates a solid distinction between these two
types of targets based on what had already been implemented and duplicated in
ad hoc ways before. Specifically,

- Dynamically loadable modules no longer get a soname. The numbers previously
set in the makefiles were dummy numbers anyway, and the presence of a soname
upset a few packaging tools, so it is nicer not to have one.

- The cumbersome detour taken on installation (build a libfoo.so.0.0.0 and
then override the rule to install foo.so instead) is removed.

- Lots of duplicated code simplified.

Tom Lane

tgl@sss.pgh.pa.us

almost 18 years ago

In reply to: Noname (#1)

Re: pgsql: Implement a few changes to how shared libraries and dynamically

petere@postgresql.org (Peter Eisentraut) writes:

Implement a few changes to how shared libraries and dynamically loadable
modules are built.

Seems this patch has broken all the Windows buildfarm animals ... is
anybody on that?

regards, tom lane

Andrew Dunstan

andrew@dunslane.net

almost 18 years ago

In reply to: Tom Lane (#2)

Re: [HACKERS] pgsql: Implement a few changes to how shared libraries and dynamically

Tom Lane wrote:

petere@postgresql.org (Peter Eisentraut) writes:

Implement a few changes to how shared libraries and dynamically loadable
modules are built.

Seems this patch has broken all the Windows buildfarm animals ... is
anybody on that?

Not all, only those that use the Makefile build system, i.e. MSVC is not
failing, but MinGW and Cygwin are.

Specifically, we are failing thus during initdb:

creating conversions ... FATAL: could not access file "$libdir/ascii_and_mic": No such file or directory

I can't immediately see the cause, although presumably it's the changes in Makefile.shlib that have done it.

Maybe we need to set up a Windows machine or two somewhere so that committers can test out stuff like this ...

cheers

andrew

Magnus Hagander

magnus@hagander.net

almost 18 years ago

In reply to: Andrew Dunstan (#3)

Re: [HACKERS] pgsql: Implement a few changes to how shared libraries and dynamically

Andrew Dunstan wrote:

Tom Lane wrote:

petere@postgresql.org (Peter Eisentraut) writes:

Implement a few changes to how shared libraries and dynamically
loadable modules are built.

Seems this patch has broken all the Windows buildfarm animals ... is
anybody on that?

Not all, only those that use the Makefile build system, i.e. MSVC is
not failing, but MinGW and Cygwin are.

Specifically, we are failing thus during initdb:

creating conversions ... FATAL: could not access file
"$libdir/ascii_and_mic": No such file or directory

I can't immediately see the cause, although presumably it's the
changes in Makefile.shlib that have done it.

Maybe we need to set up a Windows machine or two somewhere so that
committers can test out stuff like this ...

I offered this before, and nobody was interested at the time. I don't
have the resources to do it right now if it would be interesting now,
but I think we can put one up in a VM on one of the community managed
servers actually - as long as you don't need performance, that's
certainly doable.

(I don't have a working mingw env at all right now, still
working on setting up a proper VM with windows + msvc since
changing job, so I can't look at this specific issue right now
myself)

//Magnus