pgsql: Don't downcase entries within shared_preload_libraries et al.

Started by Tom Laneabout 9 years ago1 messagescomitters

tgl@sss.pgh.pa.us

about 9 years ago

Don't downcase entries within shared_preload_libraries et al.

load_libraries(), which processes the various xxx_preload_libraries GUCs,
was parsing them using SplitIdentifierString() which isn't really
appropriate for values that could be path names: it downcases unquoted
text, and it doesn't allow embedded whitespace unless quoted.
Use SplitDirectoriesString() instead. That also allows us to simplify
load_libraries() a bit, since canonicalize_path() is now done for it.

While this definitely seems like a bug fix, it has the potential to
break configuration settings that accidentally worked before because
of the downcasing behavior. Also, there's an easy workaround for the
bug, namely to double-quote troublesome text. Hence, no back-patch.

QL Zhuo, tweaked a bit by me

Discussion: /messages/by-id/CAB-oJtxHVDc3H+Km3CjB9mY1VDzuyaVH_ZYSz7iXcRqCtb93Ew@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a69dfe5f40f77d586e8d4d9ecfc39d81612c7dda

Modified Files
--------------
src/backend/utils/adt/varlena.c | 4 +++-
src/backend/utils/init/miscinit.c | 21 +++++++++------------
2 files changed, 12 insertions(+), 13 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers