pgsql: Improve logic for finding object files on OBJS lines in contrib

Started by Nonameover 17 years ago13 messages
#1Noname
adunstan@postgresql.org

Log Message:
-----------
Improve logic for finding object files on OBJS lines in contrib Makefiles. If this unbreaks buildfarm mastodon, apply everywhere.

Modified Files:
--------------
pgsql/src/tools/msvc:
Mkvcbuild.pm (r1.27 -> r1.28)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/msvc/Mkvcbuild.pm?r1=1.27&r2=1.28)

#2Alvaro Herrera
alvherre@commandprompt.com
In reply to: Noname (#1)
Re: pgsql: Improve logic for finding object files on OBJS lines in contrib

Andrew Dunstan wrote:

Log Message:
-----------
Improve logic for finding object files on OBJS lines in contrib Makefiles. If this unbreaks buildfarm mastodon, apply everywhere.

I start to wonder why don't we just implement our own make in Perl ...

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#2)
Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

Alvaro Herrera <alvherre@commandprompt.com> writes:

Andrew Dunstan wrote:

Log Message:
-----------
Improve logic for finding object files on OBJS lines in contrib Makefiles. If this unbreaks buildfarm mastodon, apply everywhere.

I start to wonder why don't we just implement our own make in Perl ...

http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat

regards, tom lane

#4Andrew Dunstan
andrew@dunslane.net
In reply to: Alvaro Herrera (#2)
Re: pgsql: Improve logic for finding object files on OBJS lines in contrib

Alvaro Herrera wrote:

Andrew Dunstan wrote:

Log Message:
-----------
Improve logic for finding object files on OBJS lines in contrib Makefiles. If this unbreaks buildfarm mastodon, apply everywhere.

I start to wonder why don't we just implement our own make in Perl ...

Had we but world enough and time ...

cheers

andrew

#5Andrew Dunstan
andrew@dunslane.net
In reply to: Tom Lane (#3)
Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

Tom Lane wrote:

Alvaro Herrera <alvherre@commandprompt.com> writes:

Andrew Dunstan wrote:

Log Message:
-----------
Improve logic for finding object files on OBJS lines in contrib Makefiles. If this unbreaks buildfarm mastodon, apply everywhere.

I start to wonder why don't we just implement our own make in Perl ...

http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat

The point is not to emulate make. Gmake for windows already exists,
anyway. The point is that building for MSVC is so very different from
the way you build everywhere else. Our current tools build MSVC project
files and then drive the build from there. Having a make equivalent
won't help us much.

cheers

andrew

#6Magnus Hagander
magnus@hagander.net
In reply to: Andrew Dunstan (#5)
Re: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

Andrew Dunstan wrote:

Tom Lane wrote:

Alvaro Herrera <alvherre@commandprompt.com> writes:

Andrew Dunstan wrote:

Log Message:
-----------
Improve logic for finding object files on OBJS lines in contrib
Makefiles. If this unbreaks buildfarm mastodon, apply everywhere.

I start to wonder why don't we just implement our own make in
Perl ...

http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat

The point is not to emulate make. Gmake for windows already exists,
anyway. The point is that building for MSVC is so very different from
the way you build everywhere else. Our current tools build MSVC
project files and then drive the build from there. Having a make
equivalent won't help us much.

Right. The easiest way if you're building something for scratch is to
use a system that natively supports msvc, such as cmake. But that means
a complete replacement of the build system, which is certainly
"somewhat invasive".. ;-)

//Magnus

#7Alvaro Herrera
alvherre@commandprompt.com
In reply to: Andrew Dunstan (#5)
Re: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

Andrew Dunstan wrote:

Tom Lane wrote:

Alvaro Herrera <alvherre@commandprompt.com> writes:

Andrew Dunstan wrote:

Log Message:
-----------
Improve logic for finding object files on OBJS lines in contrib Makefiles. If this unbreaks buildfarm mastodon, apply everywhere.

I start to wonder why don't we just implement our own make in Perl ...

http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat

The point is not to emulate make. Gmake for windows already exists,
anyway. The point is that building for MSVC is so very different from
the way you build everywhere else. Our current tools build MSVC project
files and then drive the build from there. Having a make equivalent
won't help us much.

What I was actually thinking was using this make reimplementation to
generate the MSVC project files, instead of parsing the makefiles to do
the same. So we would need extra Makefiles with infrastructure to do
that, but we would get away from the text parsing business.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

#8Peter Eisentraut
peter_e@gmx.net
In reply to: Tom Lane (#3)
Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

Am Freitag, 9. Mai 2008 schrieb Tom Lane:

Alvaro Herrera <alvherre@commandprompt.com> writes:

Andrew Dunstan wrote:

Log Message:
-----------
Improve logic for finding object files on OBJS lines in contrib
Makefiles. If this unbreaks buildfarm mastodon, apply everywhere.

I start to wonder why don't we just implement our own make in Perl ...

http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat

Interesting.

But surely putting a GNU make binary at some download location would be even
easier.

#9Peter Eisentraut
peter_e@gmx.net
In reply to: Magnus Hagander (#6)
Re: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

Am Freitag, 9. Mai 2008 schrieb Magnus Hagander:

Right. The easiest way if you're building something for scratch is to
use a system that natively supports msvc, such as cmake. But that means
a complete replacement of the build system, which is certainly
"somewhat invasive".. ;-)

For the record, I'd be interested in trying out cmake.

#10Andrew Dunstan
andrew@dunslane.net
In reply to: Peter Eisentraut (#8)
Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

Peter Eisentraut wrote:

Am Freitag, 9. Mai 2008 schrieb Tom Lane:

Alvaro Herrera <alvherre@commandprompt.com> writes:

Andrew Dunstan wrote:

Log Message:
-----------
Improve logic for finding object files on OBJS lines in contrib
Makefiles. If this unbreaks buildfarm mastodon, apply everywhere.

I start to wonder why don't we just implement our own make in Perl ...

http://search.cpan.org/~mhosken/Font-Fret-1.202/pmake.bat

Interesting.

But surely putting a GNU make binary at some download location would be even
easier.

As I have already pointed out elsewhere:

"The point is not to emulate make. Gmake for windows already exists,
anyway. The point is that building for MSVC is so very different from
the way you build everywhere else. Our current tools build MSVC project
files and then drive the build from there. Having a make equivalent
won't help us much. "

cheers

andrew

#11Alvaro Herrera
alvherre@commandprompt.com
In reply to: Peter Eisentraut (#9)
Re: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

Peter Eisentraut wrote:

Am Freitag, 9. Mai 2008 schrieb Magnus Hagander:

Right. The easiest way if you're building something for scratch is to
use a system that natively supports msvc, such as cmake. But that means
a complete replacement of the build system, which is certainly
"somewhat invasive".. ;-)

For the record, I'd be interested in trying out cmake.

Then let's talk about it at the developer's meeting.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

#12Magnus Hagander
magnus@hagander.net
In reply to: Alvaro Herrera (#11)
Re: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

Alvaro Herrera wrote:

Peter Eisentraut wrote:

Am Freitag, 9. Mai 2008 schrieb Magnus Hagander:

Right. The easiest way if you're building something for scratch
is to use a system that natively supports msvc, such as cmake.
But that means a complete replacement of the build system, which
is certainly "somewhat invasive".. ;-)

For the record, I'd be interested in trying out cmake.

Then let's talk about it at the developer's meeting.

+1. If there is time, let's please add that to the schedule.

//Magnus

#13Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#11)
Re: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib

Alvaro Herrera <alvherre@commandprompt.com> writes:

Peter Eisentraut wrote:

For the record, I'd be interested in trying out cmake.

Then let's talk about it at the developer's meeting.

Is there anything that will be useful to say unless someone's done
some experiments to look at?

regards, tom lane