pgsql: Changed order of statements and added an additiona MSVC safeguar

Started by Michael Meskesalmost 9 years ago3 messagescomitters
Jump to latest
#1Michael Meskes
meskes@postgresql.org

Changed order of statements and added an additiona MSVC safeguard to make ecpg
thread test cases work on Windows.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/04fbe0e4516d26de9420637f6fc90041e574b4b0

Modified Files
--------------
src/interfaces/ecpg/test/expected/thread-alloc.c | 36 ++++++------
.../ecpg/test/expected/thread-descriptor.c | 10 ++--
src/interfaces/ecpg/test/expected/thread-prep.c | 64 +++++++++++-----------
src/interfaces/ecpg/test/expected/thread-thread.c | 38 +++++++------
.../ecpg/test/expected/thread-thread_implicit.c | 38 +++++++------
src/interfaces/ecpg/test/thread/alloc.pgc | 10 ++--
src/interfaces/ecpg/test/thread/descriptor.pgc | 2 +
src/interfaces/ecpg/test/thread/prep.pgc | 10 ++--
src/interfaces/ecpg/test/thread/thread.pgc | 10 ++--
.../ecpg/test/thread/thread_implicit.pgc | 10 ++--
10 files changed, 124 insertions(+), 104 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Michael Meskes (#1)
Re: pgsql: Changed order of statements and added an additiona MSVC safeguar

Michael Meskes <meskes@postgresql.org> writes:

Changed order of statements and added an additiona MSVC safeguard to make ecpg
thread test cases work on Windows.

Now that some buildfarm owners have enabled ecpg tests on their Windows
machines, it'd be a good idea to back-patch this. I see that woodlouse
is consistently succeeding on the master branch, but v10 not so much,
and this commit is the only plausible reason why.

regards, tom lane

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Michael Meskes
meskes@postgresql.org
In reply to: Tom Lane (#2)
Re: pgsql: Changed order of statements and added an additiona MSVC safeguar

Now that some buildfarm owners have enabled ecpg tests on their Windows
machines, it'd be a good idea to back-patch this. I see that woodlouse
is consistently succeeding on the master branch, but v10 not so much,
and this commit is the only plausible reason why.

Done for 9.6 and 10. There were some other changes to the regressions
tests for 9.6, so the patches in question do not apply cleanly in 9.5
and earlier and I kind of doubt that it's worth the effort to manually
backport.

Michael

P.S.: I'm traveling, if something goes red because of this commit, feel
free to fix. :)
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers