pgsql: Remove endof macro

Started by Peter Eisentrautalmost 9 years ago3 messagescomitters
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

Remove endof macro

It has not been used in a long time, and it doesn't seem safe anyway, so
drop it.

Reviewed-by: Michael Paquier <michael.paquier@gmail.com>
Reviewed-by: Ryan Murphy <ryanfmurphy@gmail.com>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/153a49bb331005bf70b1e76e69fe28f1c417cc91

Modified Files
--------------
src/include/c.h | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Andres Freund
andres@anarazel.de
In reply to: Peter Eisentraut (#1)
Re: pgsql: Remove endof macro

Hi,

On 2017-09-05 19:08:06 +0000, Peter Eisentraut wrote:

Remove endof macro

It has not been used in a long time, and it doesn't seem safe anyway, so
drop it.

I've no problem removing this, but why isn't it safe? It's explicitly
allowed to compute (not dereference) the address of
end-of-array-plus-one.

Andres

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Andres Freund (#2)
Re: pgsql: Remove endof macro

On 9/5/17 15:10, Andres Freund wrote:

On 2017-09-05 19:08:06 +0000, Peter Eisentraut wrote:

Remove endof macro

It has not been used in a long time, and it doesn't seem safe anyway, so
drop it.

I've no problem removing this, but why isn't it safe? It's explicitly
allowed to compute (not dereference) the address of
end-of-array-plus-one.

You are right. I misinterpreted some of the old commits.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers