pgsql: Improve vpath support in plperl build

Started by Peter Eisentrautover 8 years ago3 messagescomitters
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

Improve vpath support in plperl build

Run xsubpp with the -output option instead of redirecting stdout. That
ensures that the #line directives in the output file point to the right
place in a vpath build. This in turn fixes an error in coverage builds
that it can't find the source files.

Refactor the makefile rules while we're here.

Reviewed-by: Michael Paquier <michael.paquier@gmail.com>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/639928c988c1c2f52bbe7ca89e8c7c78a041b3e2

Modified Files
--------------
src/pl/plperl/GNUmakefile | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: pgsql: Improve vpath support in plperl build

Peter Eisentraut <peter_e@gmx.net> writes:

Improve vpath support in plperl build

A fair chunk of the buildfarm doesn't like this. It looks like
xsubpp's "-output" option is a johnny-come-lately.

regards, tom lane

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Tom Lane (#2)
Re: pgsql: Improve vpath support in plperl build

On 9/27/17 15:14, Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

Improve vpath support in plperl build

A fair chunk of the buildfarm doesn't like this. It looks like
xsubpp's "-output" option is a johnny-come-lately.

Yup, fixed that.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers