pgsql: Clean up duplicate role and schema names in regression tests.
Clean up duplicate role and schema names in regression tests.
Since these names are global, using the same ones in different regression
tests creates a hazard of test failures if any two such scripts run
concurrently. Let's establish a policy of not doing that. In the cases
where a conflict existed, I chose to rename both sides: in principle one
script or the other could've been left in possession of the common name,
but that seems to just invite more trouble of the same sort.
There are a number of places where scripts are using names that seem
unduly generic, but in the absence of actual conflicts I left them alone.
In addition, fix insert.sql's use of "someone_else" as a role name.
That's a flat out violation of longstanding project policy, so back-patch
that change to v10 where the usage appeared. The rest of this is just
future-proofing, as no two of these scripts are actually run concurrently
in the existing parallel_schedule.
Conflicts of schema-qualified names also exist, but will be dealt with
separately.
Discussion: /messages/by-id/4627.1521070268@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/fb7db40ad26c3384f81d471442743076ade3f82a
Modified Files
--------------
src/test/regress/expected/alter_generic.out | 306 ++++++-------
src/test/regress/expected/alter_table.out | 10 +-
src/test/regress/expected/create_procedure.out | 12 +-
src/test/regress/expected/create_view.out | 2 +-
src/test/regress/expected/identity.out | 8 +-
src/test/regress/expected/insert.out | 18 +-
src/test/regress/expected/namespace.out | 36 +-
src/test/regress/expected/privileges.out | 598 ++++++++++++-------------
src/test/regress/expected/rolenames.out | 4 +-
src/test/regress/sql/alter_generic.sql | 158 +++----
src/test/regress/sql/alter_table.sql | 10 +-
src/test/regress/sql/create_procedure.sql | 12 +-
src/test/regress/sql/create_view.sql | 2 +-
src/test/regress/sql/identity.sql | 8 +-
src/test/regress/sql/insert.sql | 18 +-
src/test/regress/sql/namespace.sql | 28 +-
src/test/regress/sql/privileges.sql | 494 ++++++++++----------
src/test/regress/sql/rolenames.sql | 4 +-
18 files changed, 864 insertions(+), 864 deletions(-)