pgsql: Restore erroneously removed ONLY from PK check

Started by Alvaro Herreraover 8 years ago3 messagescomitters
Jump to latest
#1Alvaro Herrera
alvherre@2ndquadrant.com

Restore erroneously removed ONLY from PK check

This is a blind fix, since I don't have SE-Linux to verify it.

Per unwanted change in rhinoceros, running sepgsql tests. Noted by Tom
Lane.

Discussion: /messages/by-id/32347.1522865050@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7d7c99790b2a7e6f4e5287a3fb29f73cedbb2105

Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

#2Andres Freund
andres@anarazel.de
In reply to: Alvaro Herrera (#1)
Re: pgsql: Restore erroneously removed ONLY from PK check

On 2018-04-04 19:38:57 +0000, Alvaro Herrera wrote:

Restore erroneously removed ONLY from PK check

This is a blind fix, since I don't have SE-Linux to verify it.

Per unwanted change in rhinoceros, running sepgsql tests. Noted by Tom
Lane.

Discussion: /messages/by-id/32347.1522865050@sss.pgh.pa.us

Branch
------
master

Shouldn't the difference due to the ONLY be visible in cases with
inheritance? As in, spuriously succeeding or such? Seems like
something that a normal regression test would be good for?

Greetings,

Andres Freund

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andres Freund (#2)
Re: pgsql: Restore erroneously removed ONLY from PK check

Andres Freund <andres@anarazel.de> writes:

Shouldn't the difference due to the ONLY be visible in cases with
inheritance? As in, spuriously succeeding or such? Seems like
something that a normal regression test would be good for?

Yeah, if it actually matters (which I think it does), it shouldn't be hard
to devise a regression test that shows a behavioral difference.

regards, tom lane