pgsql: Fix plan cache issue in PL/pgSQL CALL

Started by Peter Eisentrautabout 8 years ago1 messagescomitters

peter_e@gmx.net

about 8 years ago

Fix plan cache issue in PL/pgSQL CALL

If we are not going to save the plan, then we need to unset expr->plan
after we are done, also in error cases. Otherwise, we get a dangling
pointer next time around.

This is not the ideal solution. It would be better if we could convince
SPI not to associate a cached plan with a resource owner, and then we
could just save the plan in all cases. But that would require bigger
surgery.

Reported-by: Pavel Stehule <pavel.stehule@gmail.com>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b9986551e0c6129300b9d7a387baf2006724b297

Modified Files
--------------
src/pl/plpgsql/src/expected/plpgsql_call.out | 10 ++++++++++
src/pl/plpgsql/src/pl_exec.c | 30 ++++++++++++++++++++++++----
src/pl/plpgsql/src/sql/plpgsql_call.sql | 4 ++++
3 files changed, 40 insertions(+), 4 deletions(-)