pgsql: Test conversion of NaN between float4 and float8.

Started by Tom Laneover 8 years ago3 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Test conversion of NaN between float4 and float8.

Results from buildfarm member opossum suggest that this doesn't work
quite right on that platform. We've seen issues with NaN support on
MIPS/NetBSD before ... allegedly they fixed this stuff back in 2010,
but maybe only for small values of "fixed".

If, in fact, opossum fails this test then I plan to revert it;
it's mainly for diagnostic purposes rather than something we'd
necessarily keep long-term. I think that the failures in window.sql
could be worked around with some code duplication, but I want to
verify my theory about the cause first.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/55e0e458170c76c1a0074cd550a13ec47e38a3fa

Modified Files
--------------
src/test/regress/expected/float4-exp-three-digits.out | 12 ++++++++++++
src/test/regress/expected/float4.out | 12 ++++++++++++
src/test/regress/sql/float4.sql | 2 ++
3 files changed, 26 insertions(+)

#2Glyn Astill
glynastill@yahoo.co.uk
In reply to: Tom Lane (#1)
Re: pgsql: Test conversion of NaN between float4 and float8.

Apologies Tom, I missed this; opossum is running one of its infrequent build runs now.

--------------------------------------------
On Sat, 21/4/18, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Subject: pgsql: Test conversion of NaN between float4 and float8.
To: pgsql-committers@lists.postgresql.org
Date: Saturday, 21 April, 2018, 0:55

Test conversion of NaN between float4 and
float8.

Results from buildfarm member opossum
suggest that this doesn't work
quite right on that platform. 
We've seen issues with NaN support on
MIPS/NetBSD before ... allegedly they
fixed this stuff back in 2010,
but maybe only for small values of
"fixed".

If, in fact, opossum fails this test
then I plan to revert it;
it's mainly for diagnostic purposes
rather than something we'd
necessarily keep long-term.  I
think that the failures in window.sql
could be worked around with some code
duplication, but I want to
verify my theory about the cause
first.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/55e0e458170c76c1a0074cd550a13ec47e38a3fa

Modified Files
--------------
src/test/regress/expected/float4-exp-three-digits.out
| 12 ++++++++++++
src/test/regress/expected/float4.out   
              | 12
++++++++++++
src/test/regress/sql/float4.sql 
               
    |  2 ++
3 files changed, 26 insertions(+)

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Glyn Astill (#2)
Re: pgsql: Test conversion of NaN between float4 and float8.

Glyn Astill <glynastill@yahoo.co.uk> writes:

Apologies Tom, I missed this; opossum is running one of its infrequent build runs now.

Thanks! I've pushed something I think will fix it, so please launch
another HEAD run, if you're scheduling that manually.

regards, tom lane