pgsql: Fix wrong file path in header comment

Started by Alexander Korotkovabout 8 years ago4 messagescomitters
Jump to latest
#1Alexander Korotkov
aekorotkov@gmail.com

Fix wrong file path in header comment

Header comment of shm_mq.c was mistakenly specifying path to shm_mq.h.
It was introduced in ec9037df. So, theoretically it could be
backpatched to 9.4, but it doesn't seem to worth it.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a01d0fa1d889cc2003e1941e8b98707c4d701ba9

Modified Files
--------------
src/backend/storage/ipc/shm_mq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

#2Alexander Korotkov
aekorotkov@gmail.com
In reply to: Alexander Korotkov (#1)
Re: pgsql: Fix wrong file path in header comment

On Wed, Jul 11, 2018 at 1:26 PM Alexander Korotkov
<akorotkov@postgresql.org> wrote:

Header comment of shm_mq.c was mistakenly specifying path to shm_mq.h.
It was introduced in ec9037df. So, theoretically it could be
backpatched to 9.4, but it doesn't seem to worth it.

I didn't backpatch, because I thought it doesn't worth it to create
buzz over single wrong path in the comment. But, I found 12 similar
cases in our source tree. Do you think it worth backpatching now?

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachments:

header-comment-filepath-fix.patchapplication/octet-stream; name=header-comment-filepath-fix.patchDownload+13-13
#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alexander Korotkov (#2)
Re: pgsql: Fix wrong file path in header comment

Alexander Korotkov <a.korotkov@postgrespro.ru> writes:

I didn't backpatch, because I thought it doesn't worth it to create
buzz over single wrong path in the comment. But, I found 12 similar
cases in our source tree. Do you think it worth backpatching now?

Nah, just fix 'em in HEAD.

regards, tom lane

#4Alexander Korotkov
aekorotkov@gmail.com
In reply to: Tom Lane (#3)
Re: pgsql: Fix wrong file path in header comment

On Wed, Jul 11, 2018 at 5:36 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

Alexander Korotkov <a.korotkov@postgrespro.ru> writes:

I didn't backpatch, because I thought it doesn't worth it to create
buzz over single wrong path in the comment. But, I found 12 similar
cases in our source tree. Do you think it worth backpatching now?

Nah, just fix 'em in HEAD.

OK, thanks.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company