pgsql: Change extension of spilled ReorderBufferChange data to ".tmp".

Started by Jeff Davisalmost 8 years ago3 messagescomitters
Jump to latest
#1Jeff Davis
pgsql@j-davis.com

Change extension of spilled ReorderBufferChange data to ".tmp".

The previous extension, ".snap", was chosen for historical reasons and
became confusing.

Discussion: /messages/by-id/CAMp0ubd_P8vBGx8=MfDXQJZxHA5D_Zarw5cCkDxJ_63+pWRJ9w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/91f26d5fe47e3b06e878f2f1949cbd35e9576c16

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

#2Andres Freund
andres@anarazel.de
In reply to: Jeff Davis (#1)
Re: pgsql: Change extension of spilled ReorderBufferChange data to ".tmp".

Hi,

On August 25, 2018 9:39:12 AM PDT, Jeff Davis <jdavis@postgresql.org> wrote:

Change extension of spilled ReorderBufferChange data to ".tmp".

The previous extension, ".snap", was chosen for historical reasons and
became confusing.

Not a fan of .tmp, that well just lead to people deleting them while the server is running etc. How about .spill or such?

Andres

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andres Freund (#2)
Re: pgsql: Change extension of spilled ReorderBufferChange data to ".tmp".

Andres Freund <andres@anarazel.de> writes:

On August 25, 2018 9:39:12 AM PDT, Jeff Davis <jdavis@postgresql.org> wrote:

Change extension of spilled ReorderBufferChange data to ".tmp".
The previous extension, ".snap", was chosen for historical reasons and
became confusing.

Not a fan of .tmp, that well just lead to people deleting them while the server is running etc. How about .spill or such?

Agreed, ".tmp" seems like a bad idea.

regards, tom lane