pgsql: doc: use simpler language for NULL return from ANY/ALL

Started by Bruce Momjianover 7 years ago3 messagescomitters
Jump to latest
#1Bruce Momjian
bruce@momjian.us

doc: use simpler language for NULL return from ANY/ALL

Previously the combination of "does not return" and "any row" caused
ambiguity.

Reported-by: KES <kes-kes@yandex.ru>

Discussion: /messages/by-id/153701242703.22334.1476830122267077397@wrigleys.postgresql.org

Reviewed-by: David G. Johnston

Backpatch-through: 9.3

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8610c973ddf1cbf0befc1369d2cf0d56c0efcd0a

Modified Files
--------------
doc/src/sgml/func.sgml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#1)
Re: pgsql: doc: use simpler language for NULL return from ANY/ALL

Bruce Momjian <bruce@momjian.us> writes:

doc: use simpler language for NULL return from ANY/ALL
Previously the combination of "does not return" and "any row" caused
ambiguity.

IMO this is not an improvement. It's turned something that read
reasonably well into something that sounds like it was written by
a not very good speaker of English. In particular, the lack of
grammatical matching between the two parts of the sentence is now
quite confusing:

The result is NULL if no comparison with a subquery row returns true,
and it returns NULL for at least one row.

The antecedent of "it" was clear before, and is not now, at least to me.

Maybe you could replace that clause with "..., and at least one comparison
returns NULL."

regards, tom lane

#3Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#2)
Re: pgsql: doc: use simpler language for NULL return from ANY/ALL

On Fri, Nov 2, 2018 at 10:20:21AM -0400, Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

doc: use simpler language for NULL return from ANY/ALL
Previously the combination of "does not return" and "any row" caused
ambiguity.

IMO this is not an improvement. It's turned something that read
reasonably well into something that sounds like it was written by
a not very good speaker of English. In particular, the lack of
grammatical matching between the two parts of the sentence is now
quite confusing:

The result is NULL if no comparison with a subquery row returns true,
and it returns NULL for at least one row.

The antecedent of "it" was clear before, and is not now, at least to me.

Maybe you could replace that clause with "..., and at least one comparison
returns NULL."

Agreed, done.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +