pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan

Started by Tom Laneover 7 years ago1 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Fix configure's AC_CHECK_DECLS tests to work correctly with clang.

The test case that Autoconf uses to discover whether a function has
been declared doesn't work reliably with clang, because clang reports
a warning not an error if the name is a known built-in function.
On some platforms, this results in a lot of compile-time warnings about
strlcpy and related functions not having been declared.

There is a fix for this (by Noah Misch) in the upstream Autoconf sources,
but since they've not made a release in years and show no indication of
doing so anytime soon, let's just absorb their fix directly. We can
revert this when and if we update to a newer Autoconf release.

Back-patch to all supported branches.

Discussion: /messages/by-id/26819.1542515567@sss.pgh.pa.us

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/593320abac7d3caa9a5b2fe4c97da32714548c8e

Modified Files
--------------
aclocal.m4 | 1 +
config/check_decls.m4 | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++
configure | 100 +++++++++++++++++++++++++++++++++++++++++--
configure.in | 5 ++-
4 files changed, 217 insertions(+), 5 deletions(-)