pgsql: Improve error messages for incorrect types of logical replicatio
Improve error messages for incorrect types of logical replication targets
If trying to use something else than a plain table as logical
replication target, a rather-generic error message gets used to report
the problem. This can be confusing when it comes to foreign tables and
partitioned tables, so use more dedicated messages in these cases.
Author: Amit Langote
Reviewed-by: Peter Eisentraut, Magnus Hagander, Michael Paquier
Discussion: /messages/by-id/41799bee-40eb-7bb5-80b1-325ce17518bc@lab.ntt.co.jp
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/373bda61d2d620e704815553978726c9be9e1209
Modified Files
--------------
src/backend/executor/execReplication.c | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
On 2019-01-13 08:45, Michael Paquier wrote:
Improve error messages for incorrect types of logical replication
targetsDiscussion:
/messages/by-id/41799bee-40eb-7bb5-80b1-325ce17518bc@lab.ntt.co.jpmaster
https://git.postgresql.org/pg/commitdiff/373bda61d2d620e704815553978726c9be9e1209Modified Files
--------------
src/backend/executor/execReplication.c | 22 ++++++++++++++++++++--
Good idea, but now one message (for RELKIND_FOREIGN_TABLE) omits
'target'.
So I think
errmsg("cannot use relation \"%s.%s\" as logical replication"
should be:
errmsg("cannot use relation \"%s.%s\" as logical replication target"
Do you agree?
Thanks,
Erik Rijkers