pgsql: Remove superfluous tqual.h includes.

Started by Andres Freundover 7 years ago3 messagescomitters
Jump to latest
#1Andres Freund
andres@anarazel.de

Remove superfluous tqual.h includes.

Most of these had been obsoleted by 568d4138c / the SnapshotNow
removal.

This is is preparation for moving most of tqual.[ch] into either
snapmgr.h or heapam.h, which in turn is in preparation for pluggable
table AMs.

Author: Andres Freund
Discussion: /messages/by-id/20180703070645.wchpu5muyto5n647@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e7cc78ad43eb1a6ea43dbb46c83264d2d00e402c

Modified Files
--------------
contrib/dblink/dblink.c | 1 -
contrib/sepgsql/label.c | 1 -
src/backend/access/index/indexam.c | 1 -
src/backend/access/nbtree/nbtinsert.c | 1 -
src/backend/access/nbtree/nbtsearch.c | 1 -
src/backend/bootstrap/bootstrap.c | 1 -
src/backend/catalog/aclchk.c | 1 -
src/backend/catalog/catalog.c | 1 -
src/backend/catalog/dependency.c | 1 -
src/backend/catalog/heap.c | 1 -
src/backend/catalog/objectaddress.c | 1 -
src/backend/catalog/pg_collation.c | 1 -
src/backend/catalog/pg_constraint.c | 1 -
src/backend/catalog/pg_conversion.c | 1 -
src/backend/catalog/pg_db_role_setting.c | 1 -
src/backend/catalog/pg_depend.c | 1 -
src/backend/catalog/pg_enum.c | 1 -
src/backend/catalog/pg_inherits.c | 1 -
src/backend/catalog/pg_largeobject.c | 1 -
src/backend/catalog/pg_range.c | 1 -
src/backend/catalog/pg_shdepend.c | 1 -
src/backend/commands/alter.c | 1 -
src/backend/commands/comment.c | 1 -
src/backend/commands/dbcommands.c | 1 -
src/backend/commands/event_trigger.c | 1 -
src/backend/commands/extension.c | 1 -
src/backend/commands/functioncmds.c | 1 -
src/backend/commands/indexcmds.c | 1 -
src/backend/commands/opclasscmds.c | 1 -
src/backend/commands/proclang.c | 1 -
src/backend/commands/seclabel.c | 1 -
src/backend/commands/tablecmds.c | 1 -
src/backend/commands/tablespace.c | 1 -
src/backend/commands/trigger.c | 1 -
src/backend/commands/tsearchcmds.c | 1 -
src/backend/commands/user.c | 1 -
src/backend/commands/vacuum.c | 1 -
src/backend/executor/execMain.c | 1 -
src/backend/executor/execReplication.c | 1 -
src/backend/executor/nodeLockRows.c | 1 -
src/backend/postmaster/autovacuum.c | 1 -
src/backend/postmaster/pgstat.c | 1 -
src/backend/replication/logical/worker.c | 1 -
src/backend/rewrite/rewriteDefine.c | 1 -
src/backend/rewrite/rewriteRemove.c | 1 -
src/backend/rewrite/rewriteSupport.c | 1 -
src/backend/storage/large_object/inv_api.c | 1 -
src/backend/utils/adt/ruleutils.c | 1 -
src/backend/utils/adt/tid.c | 1 -
src/backend/utils/cache/catcache.c | 1 -
src/backend/utils/cache/relcache.c | 1 -
src/backend/utils/cache/ts_cache.c | 1 -
src/backend/utils/init/postinit.c | 1 -
src/include/utils/tqual.h | 1 -
54 files changed, 54 deletions(-)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andres Freund (#1)
Re: pgsql: Remove superfluous tqual.h includes.

Andres Freund <andres@anarazel.de> writes:

Remove superfluous tqual.h includes.

You probably already noticed that this broke everything.

regards, tom lane

#3Andres Freund
andres@anarazel.de
In reply to: Tom Lane (#2)
Re: pgsql: Remove superfluous tqual.h includes.

Hi,

On 2019-01-21 15:54:41 -0500, Tom Lane wrote:

Andres Freund <andres@anarazel.de> writes:

Remove superfluous tqual.h includes.

You probably already noticed that this broke everything.

Yea, pushed a fix. I don't quite understand how that happened - just
before commit I again trawled through all the remaining tqual.h includes
removing the one in catalog.c, but my shell history does report that I
*successfully* rebuilt afterwards (but with make -s, so I don't know
what exactly was rebuilt). This change clearly should've triggered a
rebuild, even in a tree without --enable-depend (but my tree does have
that).

Greetings,

Andres Freund