pgsql: More message style fixes
More message style fixes
Discussion: /messages/by-id/20190515183005.GA26486@alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/75445c1515fffa581585f1b72e5b5314c1c395ce
Modified Files
--------------
src/backend/commands/copy.c | 6 ++---
src/backend/commands/publicationcmds.c | 2 +-
src/backend/commands/subscriptioncmds.c | 40 +++++++++++++++++++++------------
src/backend/commands/tablecmds.c | 8 +++----
src/backend/parser/analyze.c | 2 +-
src/backend/postmaster/postmaster.c | 7 +++---
src/backend/replication/walsender.c | 25 ++++++++++++---------
src/backend/utils/adt/jsonpath.c | 3 ++-
src/backend/utils/adt/jsonpath_exec.c | 2 +-
src/backend/utils/adt/jsonpath_scan.l | 10 ++++-----
src/backend/utils/adt/pg_locale.c | 10 +++++----
src/backend/utils/adt/regexp.c | 14 ++++++++----
12 files changed, 78 insertions(+), 51 deletions(-)
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
More message style fixes
The buildfarm thinks you forgot something.
regards, tom lane
On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote:
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
More message style fixes
The buildfarm thinks you forgot something.
One contrib module is impacted, citext, because it uses regexes and it
has multiple expected outputs. The attached brings back my build to
green. Thoughts?
I got a bit annoyed when testing this morning, so I don't mind fixing
it myself. And I still have some hours left today to look at extra
red animals if any.
--
Michael
Attachments:
fix-test-output.patchtext/x-diff; charset=us-asciiDownload+20-20
Michael Paquier <michael@paquier.xyz> writes:
On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote:
The buildfarm thinks you forgot something.
One contrib module is impacted, citext, because it uses regexes and it
has multiple expected outputs. The attached brings back my build to
green. Thoughts?
Looks reasonable, but check if any of the other tests have alternative
expected-files that you need to fix too.
regards, tom lane
On Thu, May 16, 2019 at 08:22:25PM -0400, Tom Lane wrote:
Looks reasonable, but check if any of the other tests have alternative
expected-files that you need to fix too.
I am not noticing anything else. And I have checked once before
sending the previous patch, and once again now. If I have missed one,
well... Sorry.
--
Michael
On 2019-May-17, Michael Paquier wrote:
On Thu, May 16, 2019 at 07:20:38PM -0400, Tom Lane wrote:
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
More message style fixes
The buildfarm thinks you forgot something.
One contrib module is impacted, citext, because it uses regexes and it
has multiple expected outputs. The attached brings back my build to
green. Thoughts?
Argh. Apologies, sorry for fixing so quickly.
--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services