pgsql: pg_upgrade: Improve invalid option handling

pg_upgrade: Improve invalid option handling

Currently, calling pg_upgrade with an invalid command-line option
aborts pg_upgrade but leaves a pg_upgrade_internal.log file lying
around. Reorder things a bit so that that file is not created until
all the options have been parsed.

Discussion: /messages/by-id/24c8bd05-aed1-6301-919d-8acbabdb8c24@2ndquadrant.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/aba78ab4a9509e7ed92acefd707a99425568f49f

Modified Files
--------------
src/bin/pg_upgrade/option.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)