pgsql: Add sort support routine for the inet data type.

Started by Peter Geogheganalmost 7 years ago3 messagescomitters
Jump to latest

Add sort support routine for the inet data type.

Add sort support for inet, including support for abbreviated keys.
Testing has shown that this reduces the time taken to sort medium to
large inet/cidr inputs by ~50-60% in realistic cases.

Author: Brandur Leach
Reviewed-By: Peter Geoghegan, Edmund Horner
Discussion: /messages/by-id/CABR_9B-PQ8o2MZNJ88wo6r-NxW2EFG70M96Wmcgf99G6HUQ3sw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/71dcd7438664d81235c72337cbbbfa780f7a0630

Modified Files
--------------
src/backend/utils/adt/network.c | 399 +++++++++++++++++++++++++++++++++++++
src/include/catalog/pg_amproc.dat | 3 +
src/include/catalog/pg_proc.dat | 3 +
src/test/regress/expected/inet.out | 189 ++++++++++++++++++
src/test/regress/sql/inet.sql | 95 +++++++++
5 files changed, 689 insertions(+)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Geoghegan (#1)
Re: pgsql: Add sort support routine for the inet data type.

Peter Geoghegan <pg@bowt.ie> writes:

Add sort support routine for the inet data type.

Modified Files
--------------
src/backend/utils/adt/network.c | 399 +++++++++++++++++++++++++++++++++++++
src/include/catalog/pg_amproc.dat | 3 +
src/include/catalog/pg_proc.dat | 3 +
src/test/regress/expected/inet.out | 189 ++++++++++++++++++
src/test/regress/sql/inet.sql | 95 +++++++++
5 files changed, 689 insertions(+)

[ squint ... ] Presumably there should have been a catversion bump
here?

(Probably not too important since I just pushed a bump an hour
or so earlier, but still.)

regards, tom lane

In reply to: Tom Lane (#2)
Re: pgsql: Add sort support routine for the inet data type.

On Thu, Aug 1, 2019 at 12:17 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

(Probably not too important since I just pushed a bump an hour
or so earlier, but still.)

My mistake. I'll push a catversion bump commit shortly.

--
Peter Geoghegan