pgsql: Don't include utils/array.h from acl.h.

Started by Andres Freundalmost 7 years ago1 messagescomitters
Jump to latest
#1Andres Freund
andres@anarazel.de

Don't include utils/array.h from acl.h.

For most uses of acl.h the details of how "Acl" internally looks like
are irrelevant. It might make sense to move a lot of the
implementation details into a separate header at a later point.

The main motivation of this change is to avoid including fmgr.h (via
array.h, which needs it for exposed structs) in a lot of files that
otherwise don't need it. A subsequent commit will remove the fmgr.h
include from a lot of files.

Directly include utils/array.h and utils/expandeddatum.h from the
files that need them, but previously included them indirectly, via
acl.h.

Author: Andres Freund
Discussion: /messages/by-id/20190803193733.g3l3x3o42uv4qj7l@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6a04d345fd8094058f08344af93022566222733a

Modified Files
--------------
contrib/pageinspect/hashfuncs.c | 1 +
src/backend/executor/execExpr.c | 1 +
src/backend/executor/execExprInterp.c | 1 +
src/backend/executor/execTuples.c | 1 +
src/backend/executor/nodeAgg.c | 1 +
src/backend/executor/nodeWindowAgg.c | 1 +
src/backend/partitioning/partprune.c | 1 +
src/backend/statistics/extended_stats.c | 1 +
src/backend/statistics/mcv.c | 1 +
src/backend/utils/adt/acl.c | 1 +
src/backend/utils/adt/tsvector_op.c | 1 +
src/include/catalog/objectaddress.h | 2 +-
src/include/utils/acl.h | 3 +--
src/include/utils/array.h | 2 +-
14 files changed, 14 insertions(+), 4 deletions(-)