pgsql: Cosmetic improvements for options-handling code in ECPGconnect()

Cosmetic improvements for options-handling code in ECPGconnect().

The comment describing the string format was a lie. Make it agree with
reality, add/improve some other comments, fix coding style for loops with
empty bodies. Also add an Assert that we counted parameters correctly,
because the spread-out logic for that looks pretty fragile.

No actual bugs fixed here, so no need to back-patch.

Discussion: /messages/by-id/848B1649C8A6274AA527C4472CA11EDD5FC70CBE@G01JPEXMBYT02

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b61a5e6a1f8d4d9e0bfe5d26bebfbb0687353c08

Modified Files
--------------
src/interfaces/ecpg/ecpglib/connect.c | 33 ++++++++++++++++++++++++---------
1 file changed, 24 insertions(+), 9 deletions(-)