pgsql: Drop slot's LWLock before returning from SaveSlotToPath()

Started by Peter Eisentrautabout 6 years ago1 messagescomitters

peter_e@gmx.net

about 6 years ago

Drop slot's LWLock before returning from SaveSlotToPath()

When SaveSlotToPath() is called with elevel=LOG, the early exits didn't
release the slot's io_in_progress_lock.

This could result in a walsender being stuck on the lock forever. A
possible way to get into this situation is if the offending code paths
are triggered in a low disk space situation.

Author: Pavan Deolasee <pavan.deolasee@2ndquadrant.com>
Reported-by: Craig Ringer <craig@2ndquadrant.com>
Discussion: /messages/by-id/56a138c5-de61-f553-7e8f-6789296de785@2ndquadrant.com

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2d8597ba66a1646e353c0ff755b4b0b85cd1747f

Modified Files
--------------
src/backend/replication/slot.c | 9 +++++++++
1 file changed, 9 insertions(+)