Fix for compiler warning in reloptions.c

Started by Bruce Momjianover 17 years ago3 messageshackers
Jump to latest
#1Bruce Momjian
bruce@momjian.us

The attached applied patch prevents a compiler warning; the compiler
doesn't know about our elog(ERROR) exit case.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachments:

/rtmp/difftext/x-diffDownload+2-2
#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Bruce Momjian (#1)
Re: Fix for compiler warning in reloptions.c

Bruce Momjian wrote:

The attached applied patch prevents a compiler warning; the compiler
doesn't know about our elog(ERROR) exit case.

Hmm, I don't like your fix; ISTM it would be better to set the variable
only in the default: case (or maybe change the "break" for a "return").

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

#3Bruce Momjian
bruce@momjian.us
In reply to: Alvaro Herrera (#2)
Re: Fix for compiler warning in reloptions.c

Alvaro Herrera wrote:

Bruce Momjian wrote:

The attached applied patch prevents a compiler warning; the compiler
doesn't know about our elog(ERROR) exit case.

Hmm, I don't like your fix; ISTM it would be better to set the variable
only in the default: case (or maybe change the "break" for a "return").

Agreed, I used the 'default' idea, attached, applied.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachments:

/rtmp/difftext/x-diffDownload+3-2