Textdomains

Started by Magnus Haganderabout 17 years ago3 messageshackers
Jump to latest
#1Magnus Hagander
magnus@hagander.net

I've extracted this patch from Hiroshi Inoues patch about bug #4186. Per
his comment, "It also includes the changes to mbutils.c and elog.c which
fix recently introduced bug by the domain name change from "postgres" to
"postgres-8.4"."

Can somebody who actually knows how that works comment on it, please :-)

//Magnus

Attachments:

txt_domains.patchtext/x-diff; name=txt_domains.patchDownload+2-2
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Magnus Hagander (#1)
Re: Textdomains

Magnus Hagander wrote:

I've extracted this patch from Hiroshi Inoues patch about bug #4186. Per
his comment, "It also includes the changes to mbutils.c and elog.c which
fix recently introduced bug by the domain name change from "postgres" to
"postgres-8.4"."

Can somebody who actually knows how that works comment on it, please :-)

It looks correct.

Note, however, that we now support translation of loaded modules, so you
would really need to go around and call bind_textdomain_codeset() for
all catalogs that pop up dynamically. So that part might need some more
work.

#3Magnus Hagander
magnus@hagander.net
In reply to: Peter Eisentraut (#2)
Re: Textdomains

Peter Eisentraut wrote:

Magnus Hagander wrote:

I've extracted this patch from Hiroshi Inoues patch about bug #4186. Per
his comment, "It also includes the changes to mbutils.c and elog.c which
fix recently introduced bug by the domain name change from "postgres" to
"postgres-8.4"."

Can somebody who actually knows how that works comment on it, please :-)

It looks correct.

Ok, will apply.

Note, however, that we now support translation of loaded modules, so you
would really need to go around and call bind_textdomain_codeset() for
all catalogs that pop up dynamically. So that part might need some more
work.

Well, this is a bugfix for existing stuff... Adding new stuff I'll
happily leave to someone who understands it better.. :-P

//Magnus