Compiler warning in ecpglib/execute.c

Started by Tom Lanealmost 17 years ago4 messages

tgl@sss.pgh.pa.us

almost 17 years ago

CVS HEAD is producing

execute.c: In function 'ecpg_store_result':
execute.c:394: warning: 'act_tuple' may be used uninitialized in this function

It looks to me like this is an actual bug, not just the compiler being
insufficiently smart to prove the variable is set before use.

regards, tom lane

Michael Meskes

meskes@postgresql.org

almost 17 years ago

In reply to: Tom Lane (#1)

Re: Compiler warning in ecpglib/execute.c

On Mon, Feb 02, 2009 at 02:56:18PM -0500, Tom Lane wrote:

CVS HEAD is producing
...

Thanks for the note, I missed this copy&paste error of mine. Fixed in HEAD.
This should alos make the buildfarm green again.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!

Alvaro Herrera

alvherre@alvh.no-ip.org

almost 17 years ago

In reply to: Michael Meskes (#2)

Re: Compiler warning in ecpglib/execute.c

Michael Meskes wrote:

On Mon, Feb 02, 2009 at 02:56:18PM -0500, Tom Lane wrote:

CVS HEAD is producing
...

Thanks for the note, I missed this copy&paste error of mine. Fixed in HEAD.
This should alos make the buildfarm green again.

Note that spoonbill is still red. This animal is special because it
uses some peculiar malloc flags.

--
Alvaro Herrera http://www.advogato.org/person/alvherre
"La persona que no querï¿½a pecar / estaba obligada a sentarse
en duras y empinadas sillas / desprovistas, por cierto
de blandos atenuantes" (Patricio Vogel)

Michael Meskes

meskes@postgresql.org

almost 17 years ago

In reply to: Alvaro Herrera (#3)

Re: Compiler warning in ecpglib/execute.c

On Tue, Feb 03, 2009 at 04:06:39PM -0300, Alvaro Herrera wrote:

Note that spoonbill is still red. This animal is special because it
uses some peculiar malloc flags.

Not just spoonbill, five of them are. Without access to a failing machine this
is difficult to debug. I found some missing error checks in that library that
might explain the segfaults, but I still don't see why the the test is failing.