pgsql: Fix YA incremental sort bug.

Started by Tom Laneover 5 years ago1 messagescomitters

tgl@sss.pgh.pa.us

over 5 years ago

Fix YA incremental sort bug.

switchToPresortedPrefixMode() did the wrong thing if it detected
a batch boundary just at the last tuple of a fullsort group.

The initially-reported symptom was a "retrieved too many tuples in a
bounded sort" error, but the test case added here just silently gives
the wrong answer without this patch.

I (tgl) am not really happy about committing this patch without review
from the incremental-sort authors, but they seem AWOL and we are hard
against a release deadline. This does demonstrably make some cases
better, anyway.

Per bug #16846 from Yoran Heling. Back-patch to v13 where incremental
sort was introduced.

Neil Chen

Discussion: /messages/by-id/16846-ae49f51ac379a4cb@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/82e0e29308dedbc6000e73329beb112ae7e1ad39

Modified Files
--------------
src/backend/executor/nodeIncrementalSort.c | 7 +++++++
src/test/regress/expected/incremental_sort.out | 11 +++++++++++
src/test/regress/sql/incremental_sort.sql | 3 +++
3 files changed, 21 insertions(+)