pgsql: pg_attribute_no_sanitize_alignment() macro

Started by Tom Laneover 5 years ago1 messagescomitters

tgl@sss.pgh.pa.us

over 5 years ago

pg_attribute_no_sanitize_alignment() macro

Modern gcc and clang compilers offer alignment sanitizers, which help to detect
pointer misalignment. However, our codebase already contains x86-specific
crc32 computation code, which uses unalignment access. Thankfully, those
compilers also support the attribute, which disables alignment sanitizers at
the function level. This commit adds pg_attribute_no_sanitize_alignment(),
which wraps this attribute, and applies it to pg_comp_crc32c_sse42() function.

Back-patch of commits 993bdb9f9 and ad2ad698a, to enable doing
alignment testing in all supported branches.

Discussion: /messages/by-id/CAPpHfdsne3=T=fMNU45PtxdhSL_J2PjLTeS8rwKnJzUR4YNd4w@mail.gmail.com
Discussion: /messages/by-id/475514.1612745257@sss.pgh.pa.us
Author: Alexander Korotkov, revised by Tom Lane
Reviewed-by: Tom Lane

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c86eae39ce1e5f842bbf75e381d903de43ad4c80

Modified Files
--------------
src/include/c.h | 12 ++++++++++++
src/port/pg_crc32c_sse42.c | 1 +
2 files changed, 13 insertions(+)